-
-
Notifications
You must be signed in to change notification settings - Fork 75
Changes for supporting netlify deployment #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buckhalt
wants to merge
6
commits into
main
Choose a base branch
from
netlify-deployment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy Preview for fresco-test failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the entire feedback banner and feedback modal functionality from the application, including all related components and their usage across the codebase. It also standardizes environment variable names for database connections, updates environment variable handling for improved compatibility, and adds a new build script for Netlify and Vercel deployments. Minor code cleanup and dependency updates are also included.
Removal of Feedback Banner and Related Features:
Deleted all feedback-related components, including
FeedbackBanner
,FeedbackButton
,FeedbackModal
, andSignOutModal
, as well as their usages in the dashboard, interview, and error pages. This removes the feedback UI and associated logic throughout the app. [1] [2] [3] [4] app/(interview)/interview/[interviewId]/page.tsxL4, app/(interview)/interview/[interviewId]/page.tsxL47, [5] [6] [7] [8] [9] [10]Removed the generic
Banner
component, as it was only used by the feedback banner.Environment Variable Standardization and Backwards Compatibility:
POSTGRES_PRISMA_URL
/POSTGRES_URL_NON_POOLING
toDATABASE_URL
/DATABASE_URL_UNPOOLED
in.env.example
andenv.js
, with fallback support for the old variable names for backwards compatibility. [1] [2] [3]Build Process Improvements:
build:platform
script topackage.json
and updated the Netlify and Vercel build commands to use it, ensuring database setup and initialization steps are performed during deployment. [1] [2] [3]Dependency and Code Cleanup:
@radix-ui/react-visually-hidden
dependency and the customcomponents/ui/sheet.tsx
file, as they are no longer needed after feedback modal removal. [1] [2]These changes simplify the codebase by removing unused feedback-related features and improve deployment and environment configuration consistency.