Skip to content

Don't install the LICENSE as a datafile #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dirkmueller
Copy link

Data files are installed in the wrong directory when packaging this,
and it is very uncommon to do so. data files should be files needed
for the runtime only.

@ghost
Copy link

ghost commented Oct 31, 2019

It looks like @dirkmueller hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@dirkmueller
Copy link
Author

I can not easily sign such a CLA.

@rnpridgeon
Copy link
Contributor

Thanks for bringing this to our attention. We will look into this a bit more to figure out what exactly the best practice is here. I suspect omitting the license entirely is less than ideal.

@Atheuz
Copy link

Atheuz commented Jun 15, 2022

Add in license_files key instead?
See here: https://setuptools.pypa.io/en/latest/references/keywords.html

@cla-assistant
Copy link

cla-assistant bot commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

Data files are installed in the wrong directory when packaging this,
and it is very uncommon to do so. data files should be files needed
for the runtime only.
@MSeal
Copy link

MSeal commented Jun 25, 2025

This issue appears to have been resolved by a later move to pyproject.toml -- I noticed the manifest for licenses was still odd and used the newer license fields in #2001 to further normalize the project file registration.

@MSeal MSeal closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants