Skip to content

Conversation

PratRanj07
Copy link
Contributor

Upgrade the following APIs to first flexible version

  1. AddPartitionsToTxn(0 -> 3)
  2. AddOffsetsToTxn(0 -> 3)
  3. EndTxn(1 -> 3)

@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 16:40
@PratRanj07 PratRanj07 requested a review from a team as a code owner August 22, 2025 16:40
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades three Admin APIs to their first flexible versions (version 3) as part of KIP-482 implementation: AddPartitionsToTxn, AddOffsetsToTxn, and EndTxn.

  • Updates API version support from 0-1 to 0-3 for the three APIs
  • Adds flexible versioning support with proper array count handling and tag skipping
  • Updates mock handlers to support the new API versions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/rdkafka_txnmgr.c Updates response parsing to use array count functions and skip tags for flexible versioning
src/rdkafka_request.c Upgrades API version support and adds flexible request formatting with tag handling
src/rdkafka_mock_handlers.c Updates mock handlers to support new API versions and adds tag handling in responses

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

rd_kafka_buf_skip_tags(rkbuf);

Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag skipping should be moved inside the partition loop (after line 2211) to properly handle tags for each partition entry, not after processing all partitions for a topic.

Suggested change
rd_kafka_buf_skip_tags(rkbuf);
}

Copilot uses AI. Check for mistakes.

@PratRanj07 PratRanj07 changed the title [KIP-482] Upgrade Admin Apis to flexible versions [KIP-482] Upgrade Transaction Apis to flexible versions Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant