-
Notifications
You must be signed in to change notification settings - Fork 3.2k
K2 testing final #5198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ankith-Confluent
wants to merge
78
commits into
master
Choose a base branch
from
k2_testing_final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,579
−1,431
Open
K2 testing final #5198
Changes from 63 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
9d0bd65
K2 testing commit
k-raina 9a46014
K2 testing commit
k-raina 4db0be8
K2 testing commit
k-raina 10eafca
K2 Fix ( - 81)
Ankith-Confluent 9135051
2.11 cherrypick fix
Ankith-Confluent 04103da
K2 Fix
Ankith-Confluent ba824c7
K2 fix for 0011 and 0081 for 2.11
Ankith-Confluent 39ba005
K2 Fix
Ankith-Confluent 8d536dc
Cherry-pick Fix K2
Ankith-Confluent e7520d7
k2 11 and 81 fix
Ankith-Confluent 9655b58
k2 Fix 2.8 in latest tests
Ankith-Confluent f9ab564
small fix
Ankith-Confluent 86551ff
K2 Fix for 2.7
Ankith-Confluent 160725f
Cherrypicked fix from 2.8 latest
Ankith-Confluent 8117fa3
small fix
Ankith-Confluent b6158e9
k2 Fix
Ankith-Confluent e0dcd29
k2 Fix
Ankith-Confluent b4654c8
K2 Fix
Ankith-Confluent d32bede
K2 Fix
Ankith-Confluent 24b8316
K2 Fix
Ankith-Confluent e041181
K2 Fix
Ankith-Confluent 4c42662
K2 Fix
Ankith-Confluent 37bc02b
K2 Fix
Ankith-Confluent c4c7f76
81 Fix
Ankith-Confluent 3854c71
minor fix 11 and 59
Ankith-Confluent 425e075
59 clean up
Ankith-Confluent 4ca7d6f
81 test clean up
Ankith-Confluent 31b3c20
fix for 107 and 113
Ankith-Confluent a5689d2
Fix critical K2 logic bug in 0081-admin.c - inverted condition for de…
Ankith-Confluent eb58f2c
merged 2.8
Ankith-Confluent 5b15cc2
Merge branch 'k2_testing_v2.8.0' into k2_testing_final
Ankith-Confluent 4a12f0b
Merge k2_testing_v2.8.0_latest into k2_testing_final
Ankith-Confluent bed0e3d
Merged 2.7
Ankith-Confluent 931c560
Merge branch 'k2_testing_v2.5.3-Latest' into k2_testing_final
Ankith-Confluent 09f564e
Merged 2.4
Ankith-Confluent c972992
Merge branch 'k2_testing_v2.3.0-Latest' into k2_testing_final
Ankith-Confluent 78a5d24
Merge branch 'k2_testing_v2.2.1-Latest' into k2_testing_final
Ankith-Confluent e48166c
Merge branch 'k2_testing_v2.1.1-Latest' into k2_testing_final
Ankith-Confluent bb55d4a
Merge branch 'k2_testing_v2.0.2-Latest' into k2_testing_final
Ankith-Confluent af55b2e
fix regex tests
Ankith-Confluent 0f29e67
ACKS Fix
Ankith-Confluent 4a6efcf
rd_sleep Fix
Ankith-Confluent d2dca7c
rd_sleep second fix
Ankith-Confluent bd7cff0
rd_sleep Fix 3
Ankith-Confluent be170ed
rd_sleep Fix 4
Ankith-Confluent 300afc2
rd_sleep Fix 5
Ankith-Confluent 741d2db
Removing test_k2_cluster for timeout sceneriaos
Ankith-Confluent fbb66ef
Clean up 113 112 1
Ankith-Confluent e1722dc
K2 related skip fix by adding a new config
Ankith-Confluent 863de8d
Fix couple of test , 81 mainly
Ankith-Confluent 347539d
Delete topics (0001 - 0050)
Ankith-Confluent 7e644ce
removed delete
Ankith-Confluent e93a11f
SSL skips
Ankith-Confluent 600b387
delete topics utility
Ankith-Confluent 2522cde
minro commit
Ankith-Confluent 24c066c
removed delete
Ankith-Confluent 93f9d45
delete topics utility
Ankith-Confluent 4301f9d
minor bug
Ankith-Confluent 6a15e96
Github Copilot reviews
Ankith-Confluent 8cea5dd
minor spelling mistake
Ankith-Confluent 9df1716
Removed extra lines and delete topics code
Ankith-Confluent 21538a8
removed extra lines and fixed formatting
Ankith-Confluent 4edf3d8
small fix
Ankith-Confluent 21661a6
Refactor partition list printing functions to improve version safety.…
Ankith-Confluent 566cc33
Refactor sleep function calls in tests to use sleep_for for consisten…
Ankith-Confluent 1af4193
Remove K2 cluster mode references from tests and simplify fetch confi…
Ankith-Confluent a7fc114
Update fetch configuration and topic creation in tests for consistenc…
Ankith-Confluent b4e7851
Enhance test stability by adjusting sleep durations and handling time…
Ankith-Confluent 6f83605
Improve test robustness by enhancing partition comparison logic and a…
Ankith-Confluent 3156906
clang-formatted the changes
Ankith-Confluent ff16f52
Refactor vector syntax in cooperative rebalance tests for consistency.
Ankith-Confluent cdcbdd9
clang-format 18 verison
Ankith-Confluent 2a72bf6
small styling changes
Ankith-Confluent 05946f2
Remove unnecessary topic creation call in rkt_cache test to streamlin…
Ankith-Confluent 1054fd9
Adjust sleep duration in fast metadata refresh test to improve timing…
Ankith-Confluent e3a7e68
Updated timeout duration
Ankith-Confluent c15bb21
increased time
Ankith-Confluent 06148f1
Refactor variable initialization
Ankith-Confluent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,22 +85,25 @@ int main_0007_autotopic(int argc, char **argv) { | |
| int msgcnt = 10; | ||
| int i; | ||
|
|
||
| if (!test_check_auto_create_topic()) { | ||
| TEST_SKIP( | ||
| "NOTE! This test requires " | ||
| "auto.create.topics.enable=true to be configured on " | ||
| "the broker!\n"); | ||
| return 0; | ||
| } | ||
|
|
||
| /* Generate unique topic name */ | ||
| test_conf_init(&conf, &topic_conf, 10); | ||
|
|
||
| TEST_SAY( | ||
| "\033[33mNOTE! This test requires " | ||
| "auto.create.topics.enable=true to be configured on " | ||
| "the broker!\033[0m\n"); | ||
|
|
||
| /* Set delivery report callback */ | ||
| rd_kafka_conf_set_dr_cb(conf, dr_cb); | ||
|
|
||
| /* Create kafka instance */ | ||
| rk = test_create_handle(RD_KAFKA_PRODUCER, conf); | ||
|
|
||
| rkt = rd_kafka_topic_new(rk, test_mk_topic_name("0007_autotopic", 1), | ||
| topic_conf); | ||
| const char *topic = test_mk_topic_name("0007_autotopic", 1); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't have new variables like this, we must declare |
||
| rkt = rd_kafka_topic_new(rk, topic, topic_conf); | ||
| if (!rkt) | ||
| TEST_FAIL("Failed to create topic: %s\n", rd_strerror(errno)); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,8 +96,20 @@ int main_0008_reqacks(int argc, char **argv) { | |
| "all brokers!\033[0m\n"); | ||
|
|
||
| /* Try different request.required.acks settings (issue #75) */ | ||
| for (reqacks = -1; reqacks <= 1; reqacks++) { | ||
| /* Test all standard acks values, but skip unsupported ones */ | ||
| int start_acks = -1; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. declare these with |
||
| int end_acks = 1; | ||
|
|
||
| TEST_SAY("Testing acks values -1, 0, 1 (skipping unsupported ones)\n"); | ||
| for (reqacks = start_acks; reqacks <= end_acks; reqacks++) { | ||
| char tmp[10]; | ||
|
|
||
| /* Convert acks value to string and check if supported */ | ||
| rd_snprintf(tmp, sizeof(tmp), "%d", reqacks); | ||
| if (!test_is_acks_supported(tmp)) { | ||
| TEST_SAY("Skipping acks=%d (not supported by cluster)\n", reqacks); | ||
| continue; | ||
| } | ||
|
|
||
| test_conf_init(&conf, &topic_conf, 10); | ||
|
|
||
|
|
@@ -130,6 +142,8 @@ int main_0008_reqacks(int argc, char **argv) { | |
| "expecting status %d\n", | ||
| rd_kafka_name(rk), reqacks, exp_status); | ||
|
|
||
| test_create_topic_if_auto_create_disabled(rk, topic, 1); | ||
|
|
||
| rkt = rd_kafka_topic_new(rk, topic, topic_conf); | ||
| if (!rkt) | ||
| TEST_FAIL("Failed to create topic: %s\n", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be done only once when we're in the
if (!topic)block above?