Skip to content

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Oct 1, 2025

C99 and C++98 are the new minimum standards.

Visual Studio 2015 is still supported and fully implements only C99.

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 15:43
@emasab emasab requested a review from a team as a code owner October 1, 2025 15:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the minimum C and C++ standards from gnu90 to C99 and introduces C++98 as the minimum C++ standard. The change is motivated by the fact that C99 is fully implemented in Visual Studio 2013+ and is the default in GCC 5.1.0+, making it a reasonable baseline for modern development.

  • Updated minimum C standard from gnu90 to C99
  • Introduced C++98 as the minimum C++ standard
  • Updated CI configuration to test against the new standards

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
CONTRIBUTING.md Updated documentation to reflect new C99/C++98 minimum standards and removed outdated gnu90 limitations
.semaphore/semaphore.yml Updated CI CFLAGS to use c99 and added CXXFLAGS for c++98 testing
.semaphore/semaphore-integration.yml Updated integration CI with same compiler flag changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant