Skip to content

api,adaptation,generate: allow setting kernel scheduling policy attributes. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

klihub
Copy link
Member

@klihub klihub commented Apr 10, 2025

Allow plugins to set container kernel scheduling policy attributes.

This is the corresponding Process.Scheduler OCI Spec field this PR allows adjusting: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L92

This is how Scheduler is defined in the OCI Spec: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L38

And here are the related scheduler policy and flag definitions: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L880

The related NRI types are all straightforward protobuf defined message representations of the corresponding OCI Spec types.

@klihub klihub force-pushed the devel/linux-scheduler-policy branch 3 times, most recently from e81249c to a3c9e02 Compare April 10, 2025 11:21
@klihub klihub requested review from mikebrow and fuweid May 2, 2025 08:24
@dmcgowan dmcgowan self-requested a review May 8, 2025 16:26
@klihub klihub force-pushed the devel/linux-scheduler-policy branch 3 times, most recently from 43cf40f to 237b6dc Compare June 13, 2025 07:26
@klihub klihub requested a review from djdongjin June 15, 2025 10:20
@klihub klihub force-pushed the devel/linux-scheduler-policy branch 2 times, most recently from 75064ad to bc46504 Compare July 14, 2025 14:23
@mikebrow mikebrow added the v.next to be merged into the next release label Jul 14, 2025
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub force-pushed the devel/linux-scheduler-policy branch from bc46504 to 26674c5 Compare July 14, 2025 16:08
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@klihub klihub force-pushed the devel/linux-scheduler-policy branch from 26674c5 to 653fae6 Compare July 14, 2025 18:24
@klihub
Copy link
Member Author

klihub commented Jul 15, 2025

LGTM after rebase

@mikebrow Rebased and pushed.

@mikebrow
Copy link
Member

once more to rebase/merge in #135 changes

klihub added 2 commits July 16, 2025 18:46
Allow setting/resetting container linux scheduler attributes.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the devel/linux-scheduler-policy branch from 653fae6 to a231512 Compare July 16, 2025 15:47
@klihub
Copy link
Member Author

klihub commented Jul 16, 2025

once more to rebase/merge in #135 changes

Rebased and updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v.next to be merged into the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants