bash completion fixes #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch?
|
sort entries, add some and fix some
|
Can one of the admins verify this patch?
|
smcv
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
I think this should be merged, because it's an improvement, even though it isn't complete.
Since this MR was opened, we have also gained:
Options without arguments: --share-net
Options with arguments: --bind-try --ro-bind-try --dev-bind-try --proc --json-status-fd --userns --userns2 --pidns
and the -- pseudo-argument to terminate argument parsing.
|
@smcv what do I need to do to follow-up on this? (I still use bubblewrap so I could finish the already started task) |
|
If you add the new options to this PR and force-push, that would certainly be an improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort entries, add some and fix some