Add lables for /var/kubernetes and /var/lib/kubernetes

[jcpunk]

Working with bootc and transient.etc, it is helpful to have some kubernetes elements in /var to create persistence.

Summary by Sourcery

New Features:

• Create SELinux file context labels for /var/kubernetes and /var/lib/kubernetes directories

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds labels for /var/kubernetes and /var/lib/kubernetes to enhance persistence when working with bootc and transient.etc.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added labels for /var/kubernetes and /var/lib/kubernetes.	Added a label for /var/kubernetes. Added a label for /var/lib/kubernetes.	container.fc

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @jcpunk - I've reviewed your changes - here's some feedback:

Overall Comments:

• Could you elaborate on the specific use case for these labels in the description?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[lsm5]

LGTM AFAICT.

@rhatdan @haircommander @wrabcak PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpunk, lsm5, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

These Look fine to me, but would prefer @haircommander confirm on the labels of /var/lib/kubernetes. I was thinking this might be labeled in some other place.

[lsm5]

These Look fine to me, but would prefer @haircommander confirm on the labels of /var/lib/kubernetes. I was thinking this might be labeled in some other place.

I guess it'd be nice to run some revdep tests with crio / kubernetes or whatever to ensure we don't break them, like we do with podman.

[haircommander]

what is kept in /var/lib/kubernetes? i can't find direct reference to it in the upstream but I'm probably missing something

[jcpunk]

My system has a /var/lib/kubernetes/ca.crt which seems to be the cluster CA.

[haircommander]

naively it seems closer to kubernetes_file_t to me then, though matching /var/lib/kubelet is fine too. either way, adding this makes sense to me

[jcpunk]

Related, should /var/lib/kubelet/pods have the same label as /var/lib/kubernetes/pods?

[haircommander]

hm what is in /var/lib/kubernetes/pods

[jcpunk]

My system doesn't have anything in /var/lib/kubernetes/pods. I don't even have the directory.

[haircommander]

yeah that is what I thought. no need for anything special there. pods are for the kubelet to manage so /var/lib/kubelet/pods is the only dir we'd want to have a rule for there

[jcpunk]

My eyes might be bad, but I don't see a specific rule setting /var/lib/kubelet/pods to a specific label. Just inheriting from /var/lib/kubelet. The pod-resources is getting called out...

[lsm5]

@haircommander @jcpunk do we still need this?

[jcpunk]

I would still like to see this

…

On Mon, May 19, 2025, 12:17 PM Lokesh Mandvekar ***@***.***> wrote: *lsm5* left a comment (containers/container-selinux#369) <#369 (comment)> @haircommander <https://github.com/haircommander> @jcpunk <https://github.com/jcpunk> do we still need this? — Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2673S3T7QLQCRCGPTFUGL27H7ZTAVCNFSM6AAAAAB3RMXRZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJRGU4DQMRQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[haircommander]

@jcpunk it's not clear to me what is going in these directories so it's hard to tell if these labels are correct