Containers need to use hsa devices for ROCM #384

rhatdan · 2025-07-02T11:08:30Z

Summary by Sourcery

Enhancements:

Allow containers to access HSA device nodes required by ROCm

Signed-off-by: Daniel J Walsh <[email protected]>

sourcery-ai · 2025-07-02T11:08:36Z

Reviewer's Guide

This PR extends the SELinux container policy to allow containerized workloads to access AMD ROCm HSA devices by defining a new device type for HSA and granting the container domains the needed permissions.

File-Level Changes

Change	Details	Files
Define and label a new HSA device type	Introduce `hsa_device_t` in the SELinux policy Add file context mapping for `/dev/kfd` to `hsa_device_t`	`container.te` `file_contexts`
Grant container domains access to HSA devices	Allow `container_t` open/read/write/ ioctl on `hsa_device_t` Grant the container runtime domain the same permissions	`container.te`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @rhatdan - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the SELinux policy for containers to grant them the necessary permissions to access HSA (Heterogeneous System Architecture) devices. This change is specifically aimed at enabling and improving support for ROCm (Radeon Open Compute platform) within containerized environments, ensuring applications can properly interact with GPU hardware.

Highlights

SELinux Policy Version Bump: The container SELinux policy module version has been incremented from 2.238.0 to 2.239.0.
ROCm/HSA Device Access for Containers: A new optional_policy rule has been added to allow container_domain read and write permissions (rw_chr_file_perms) to character files of type hsa_device_t. This change is essential for enabling ROCm (Radeon Open Compute platform) functionality within containers by granting them access to Heterogeneous System Architecture (HSA) devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request adds SELinux rules to allow containers to access HSA devices for ROCm. For better security and consistency, the new rule should be controlled by a tunable boolean. I've suggested this improvement.

gemini-code-assist · 2025-07-02T11:10:20Z

container.te

+optional_policy(`
+	require {
+		type hsa_device_t;
+	}
+
+	allow container_domain hsa_device_t:chr_file rw_chr_file_perms;
+')


For consistency with other device access rules in this policy and for better security, this new permission should be controlled by a tunable boolean. This allows administrators to explicitly enable HSA device access when needed, instead of granting it by default on systems with ROCm support. Please wrap this policy in a tunable_policy block and add a corresponding gen_tunable definition¹.

tunable_policy(`container_use_hsa_devices',` optional_policy(` require { type hsa_device_t; } allow container_domain hsa_device_t:chr_file rw_chr_file_perms; ') `)

Style Guide References

Footnotes

Use tunable policies for device access control to allow administrators to explicitly enable features. (link) ↩

No I don't want to wrap this in a boolean, it is needed in general for ROCM accelerators, so I want it on by default.

rhatdan · 2025-07-03T10:42:53Z

@lsm5 Can't get this merged because the tests are blocked?

lsm5 · 2025-07-03T12:30:40Z

@lsm5 Can't get this merged because the tests are blocked?

Let me check on this and get back in a bit.

lsm5

/lgtm

openshift-ci · 2025-07-03T12:41:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lsm5,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lsm5 · 2025-07-03T12:43:42Z

Bypassed rules and merged. Packit jobs are blocked on https://status.packit.dev/issues/2025-06-30-fedora-infra-migration/

Containers need to use hsa devices for ROCM

2dc187f

Signed-off-by: Daniel J Walsh <[email protected]>

openshift-ci bot added the approved label Jul 2, 2025

sourcery-ai bot approved these changes Jul 2, 2025

View reviewed changes

gemini-code-assist bot reviewed Jul 2, 2025

View reviewed changes

rhatdan added the lgtm label Jul 2, 2025

lsm5 approved these changes Jul 3, 2025

View reviewed changes

openshift-ci bot assigned lsm5 Jul 3, 2025

lsm5 merged commit 9693071 into containers:main Jul 3, 2025
2 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Containers need to use hsa devices for ROCM #384

Containers need to use hsa devices for ROCM #384

Uh oh!

rhatdan commented Jul 2, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jul 2, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 2, 2025

Uh oh!

rhatdan Jul 2, 2025

Uh oh!

rhatdan commented Jul 3, 2025

Uh oh!

lsm5 commented Jul 3, 2025

Uh oh!

lsm5 left a comment

Uh oh!

openshift-ci bot commented Jul 3, 2025

Uh oh!

Uh oh!

lsm5 commented Jul 3, 2025

Uh oh!

Uh oh!

Containers need to use hsa devices for ROCM #384

Containers need to use hsa devices for ROCM #384

Uh oh!

Conversation

rhatdan commented Jul 2, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 2, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

rhatdan Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jul 3, 2025

Uh oh!

lsm5 commented Jul 3, 2025

Uh oh!

lsm5 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 3, 2025

Uh oh!

Uh oh!

lsm5 commented Jul 3, 2025

Uh oh!

Uh oh!

rhatdan commented Jul 2, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jul 2, 2025 •

edited

Loading