test/system: Fix issue with python resolver IP type #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code would never properly select the IPv4 address instead a fallback value was selected when the IPv4 option was used, the script is updated to that both IPv4 and IPv6 will be properly selected. Signed-off-by: Penn Bauman <[email protected]>
debarshiray
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Thanks for looking into this @pennbauman ! It took me while to figure out what's going on - clearly I don't know Python or networking at all. :D
Let me see if I got it right.
You are beginning to accumulate some non-trivial commits in the project. You should consider adding yourself to the copyright notices of the files you have touched.
| @@ -24,9 +24,8 @@ load 'libs/helpers' | |||
| readonly RESOLVER_PYTHON3='\ | |||
| import socket; \ | |||
| import sys; \ | |||
| family = socket.AddressFamily.AF_INET if sys.argv[1] == "A" else 0; \ | |||
| family = socket.AddressFamily.AF_INET6 if sys.argv[1] == "AAAA" else 0; \ | |||
There was a problem hiding this comment.
Aha, family was getting overwritten to 0 in the second line if sys.argv[1] is "A", right?
| family = socket.AddressFamily.AF_INET if sys.argv[1] == "A" else 0; \ | ||
| family = socket.AddressFamily.AF_INET6 if sys.argv[1] == "AAAA" else 0; \ | ||
| addr = socket.getaddrinfo(sys.argv[2], None, family, socket.SocketKind.SOCK_RAW)[0][4][0]; \ | ||
| family = {"A": socket.AddressFamily.AF_INET, "AAAA": socket.AddressFamily.AF_INET6} |
There was a problem hiding this comment.
Are we missing a trailing semi-colon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code would never properly select the IPv4 address instead a fallback value was selected when the IPv4 option was used, the script is updated to that both IPv4 and IPv6 will be properly selected.