Skip to content

toolbox.sh: use new TOOLBOX_DO_NOT_OVERRIDE_PS1 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

toolbox.sh: use new TOOLBOX_DO_NOT_OVERRIDE_PS1 #1693

wants to merge 1 commit into from

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Aug 1, 2025

This allows users to set TOOLBOX_DO_NOT_OVERRIDE_PS1 in their shell configuration
to prevent toolbox from overriding PS1.

Addresses #1357

@juhp
toolbox.sh: respect new TOOLBOX_DO_NOT_OVERRIDE_PS1
59640ce 
This allows users to set `TOOLBOX_DO_NOT_OVERRIDE_PS1` in their shell configuration to prevent toolbox from overriding PS1.

Addresses containers#1357

Signed-off-by: Jens Petersen <[email protected]>
@juhp juhp requested a review from debarshiray as a code owner August 1, 2025 13:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/9e851622f850425598daa297d34def02

✔️ unit-test SUCCESS in 2m 18s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 34s
✔️ unit-test-restricted SUCCESS in 2m 19s
❌ system-test-fedora-rawhide-commands-options FAILURE in 54m 00s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 39m 02s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 9m 47s
✔️ system-test-fedora-42-commands-options SUCCESS in 1h 22m 31s
✔️ system-test-fedora-42-runtime-environment-arch-fedora SUCCESS in 1h 03m 16s
✔️ system-test-fedora-42-runtime-environment-ubuntu SUCCESS in 17m 41s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 22m 38s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 07m 10s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 17m 53s

@juhp
Copy link
Contributor Author

juhp commented Aug 7, 2025 •
edited
Loading

(BTW this could be reverted once toolbox no longer overwrites PS1,
but in the short-term this PR would help to bridge the gap.)

I don't understand the CI failure for system-test-fedora-rawhide-commands-options - seems to me that should be unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debarshiray debarshiray Awaiting requested review from debarshiray debarshiray is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juhp