Deprecation message when using 0.0.96 and older Toolbx container + tests #1697
Conversation
|
Build failed. ✔️ unit-test SUCCESS in 2m 11s |
There was a problem hiding this comment.
Thanks for working on this, @DaliborKr ! I didn't get a chance to try out the code changes and the test, so I only have some superficial comments.
Could you please add a link to the issue #1684 in the Git commit message, like we do in other commits? It makes it easier to follow the context of the commits in future. Otherwise, one has to open the commit in a web browser and then find the links.
There are some minor trailing whitespace and missing newline problems. The trailing whitespaces can cause confusion in future, because they can get deleted or added in future commits and cause false extra lines to show up in the diff. Git can help you detect them, if you use:
$ git config --global diff.wsErrorHighlight all... or put this in your ~/.gitconfig:
[diff]
wsErrorHighlight = all
DaliborKr
force-pushed
the
depr_flatpak_dbus_service
branch
from
494ab56 to
419bbba
Compare
|
Build failed. ✔️ unit-test SUCCESS in 2m 17s |
Added deprecation message when running a container that was created with Toolbx 0.0.96 and older, as described in #1684