pkg/utils: Preserve environment variables set by a KDE session and Konsole #1698

debarshiray · 2025-08-06T23:53:51Z

See the individual commits for details.

A KDE session sets some environment variables to influence the behaviour of various programs and to access various settings [1]. eg., if the KDE_SESSION_VERSION environment variable is absent then applications won't respect KDE's theme or display scaling settings. These environment variables are not meant to be set by the shell's start-up scripts, but directly by KDE, and hence needs to be preserved across the host operating system and Toolbx container. [1] https://userbase.kde.org/KDE_System_Administration/Environment_Variables containers#1696 containers#1698

softwarefactory-project-zuul · 2025-08-07T01:37:09Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/169e15b6a8734b49bdc557975702c654

A KDE session sets some environment variables to influence the behaviour of various programs and to access various settings [1]. eg., if the KDE_SESSION_VERSION environment variable is absent then applications won't respect KDE's theme or display scaling settings. These environment variables are not meant to be set by the shell's start-up scripts, but directly by KDE, and hence needs to be preserved across the host operating system and Toolbx container. [1] https://userbase.kde.org/KDE_System_Administration/Environment_Variables containers#1696 containers#1698

debarshiray · 2025-08-07T13:27:04Z

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/169e15b6a8734b49bdc557975702c654

❌ system-test-fedora-rawhide-commands-options FAILURE in 1h 17m 29s

The error is the same as we have seen recently on Fedora Rawhide:

fedora-rawhide | not ok 186 run: Try /etc as a command
fedora-rawhide | # tags: commands-options
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 488,
fedora-rawhide | #  in test file test/system/104-run.bats, line 814)
fedora-rawhide | #   `assert_line --index 1 "bash: line 1: exec: /etc: cannot execute: Is a directory"' failed
fedora-rawhide | # ~ /home/zuul-worker/src/github.com/containers/toolbox
fedora-rawhide | #
fedora-rawhide | # -- line differs --
fedora-rawhide | # index    : 1
fedora-rawhide | # expected : bash: line 1: exec: /etc: cannot execute: Is a directory
fedora-rawhide | # actual   : Error: failed to invoke command /etc in container fedora-toolbox-43
fedora-rawhide | # --

It seems unrelated, and is probably due to some change in Fedora Rawhide.

softwarefactory-project-zuul · 2025-08-07T14:34:28Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/33c94d81f8874210a15d515e49d70f9d

Konsole injects the name of the current profile, and the identifiers of the current tab and window into the process running inside it through the KONSOLE_PROFILE_NAME, KONSOLE_DBUS_SESSION and KONSOLE_DBUS_WINDOW environment variables respectively [1,2,3]. These are used by programs like Neovim to detect the terminal features supported by Konsole [4,5], or by users to save the shell's history separately for each profile, tab or window [6]. These environment variables are not meant to be set by the shell's start-up scripts, but directly by Konsole, and hence needs to be preserved across the host operating system and Toolbx container. Note that KONSOLE_PROFILE_NAME was later removed from Konsole [7]. However, Neovim still uses it, so it's better to preserve it. [1] Konsole commit debfec2eb3c8ede8 https://invent.kde.org/utilities/konsole/-/commit/debfec2eb3c8ede8 https://bugs.kde.org/show_bug.cgi?id=227296 [2] Konsole commit fcd815256c3729f2 https://invent.kde.org/utilities/konsole/-/commit/fcd815256c3729f2 [3] Konsole commit 07cddfe302233c35 https://invent.kde.org/utilities/konsole/-/commit/07cddfe302233c35 https://bugs.kde.org/show_bug.cgi?id=276912 https://bugs.kde.org/show_bug.cgi?id=281513 https://bugs.kde.org/show_bug.cgi?id=292309 [4] Neovim commit 5fc4c2d442f01ab5 neovim/neovim@5fc4c2d442f01ab5 neovim/neovim#3129 [5] Neovim commit 3ccd59ee8216f3da neovim/neovim@3ccd59ee8216f3da neovim/neovim#6432 neovim/neovim#6429 neovim/neovim#6430 [6] https://userbase.kde.org/Konsole/en [7] Konsole commit 9e3a30fdca2078e0 https://invent.kde.org/utilities/konsole/-/commit/9e3a30fdca2078e0 https://bugs.kde.org/show_bug.cgi?id=406955 containers#1449 containers#1696 containers#1698

softwarefactory-project-zuul · 2025-08-07T22:50:26Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/f38016d76b9c4ccd9b95851efbc64ea3

Detected by https://www.shellcheck.net/: Line 1255: if ! localtime_target=$(readlink /etc/localtime >/dev/null 2>&3) \ ^-- SC2327 (warning): This command substitution will be empty because the command's output gets redirected away. ^-- SC2328 (error): This redirection takes output away from the command substitution. See: https://www.shellcheck.net/wiki/SC2327 https://www.shellcheck.net/wiki/SC2328 Fallout from 8db414d containers#1701

Bash 5.3.0 changed the error messages shown by its exec built-in [1]. With Bash 5.2.37: $ exec /etc bash: /etc: Is a directory bash: exec: /etc: cannot execute: Is a directory With Bash 5.3.0: $ exec /etc bash: /etc: Is a directory The 'assert' function cannot directly handle compound commands. So, those need to be wrapped in 'bash -c "..."' [2]. [1] Bash commit b8c60bc9ca365f82 See how exec_builtin() handles EX_NOEXEC and EISDIR from shell_execve() to avoid printing a duplicate error message. https://cgit.git.savannah.gnu.org/cgit/bash.git/commit/?id=b8c60bc9ca365f82 [2] https://github.com/bats-core/bats-assert containers#1688 containers#1699

A KDE session sets some environment variables to influence the behaviour of various programs and to access various settings [1]. eg., if the KDE_SESSION_VERSION environment variable is absent then applications won't respect KDE's theme or display scaling settings. These environment variables are not meant to be set by the shell's start-up scripts, but directly by KDE, and hence needs to be preserved across the host operating system and Toolbx container. [1] https://userbase.kde.org/KDE_System_Administration/Environment_Variables containers#1696 containers#1698

Konsole injects the name of the current profile, and the identifiers of the current tab and window into the process running inside it through the KONSOLE_PROFILE_NAME, KONSOLE_DBUS_SESSION and KONSOLE_DBUS_WINDOW environment variables respectively [1,2,3]. These are used by programs like Neovim to detect the terminal features supported by Konsole [4,5], or by users to save the shell's history separately for each profile, tab or window [6]. These environment variables are not meant to be set by the shell's start-up scripts, but directly by Konsole, and hence needs to be preserved across the host operating system and Toolbx container. Note that KONSOLE_PROFILE_NAME was later removed from Konsole [7]. However, Neovim still uses it, so it's better to preserve it. [1] Konsole commit debfec2eb3c8ede8 https://invent.kde.org/utilities/konsole/-/commit/debfec2eb3c8ede8 https://bugs.kde.org/show_bug.cgi?id=227296 [2] Konsole commit fcd815256c3729f2 https://invent.kde.org/utilities/konsole/-/commit/fcd815256c3729f2 [3] Konsole commit 07cddfe302233c35 https://invent.kde.org/utilities/konsole/-/commit/07cddfe302233c35 https://bugs.kde.org/show_bug.cgi?id=276912 https://bugs.kde.org/show_bug.cgi?id=281513 https://bugs.kde.org/show_bug.cgi?id=292309 [4] Neovim commit 5fc4c2d442f01ab5 neovim/neovim@5fc4c2d442f01ab5 neovim/neovim#3129 [5] Neovim commit 3ccd59ee8216f3da neovim/neovim@3ccd59ee8216f3da neovim/neovim#6432 neovim/neovim#6429 neovim/neovim#6430 [6] https://userbase.kde.org/Konsole/en [7] Konsole commit 9e3a30fdca2078e0 https://invent.kde.org/utilities/konsole/-/commit/9e3a30fdca2078e0 https://bugs.kde.org/show_bug.cgi?id=406955 containers#1449 containers#1696 containers#1698

softwarefactory-project-zuul · 2025-08-08T01:00:41Z

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/731ac09a463a44219815e40f79d1863e

✔️ unit-test SUCCESS in 2m 34s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 17s
✔️ unit-test-restricted SUCCESS in 2m 26s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 15m 44s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 18m 55s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 14m 35s
❌ system-test-fedora-42-commands-options TIMED_OUT in 1h 45m 24s
❌ system-test-fedora-42-runtime-environment-arch-fedora TIMED_OUT in 1h 45m 24s
✔️ system-test-fedora-42-runtime-environment-ubuntu SUCCESS in 23m 42s
❌ system-test-fedora-41-commands-options TIMED_OUT in 1h 45m 27s
❌ system-test-fedora-41-runtime-environment-arch-fedora TIMED_OUT in 1h 45m 21s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 23m 18s

debarshiray · 2025-08-08T05:00:29Z

recheck

softwarefactory-project-zuul · 2025-08-08T06:22:06Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/eb8ad6ffe89e400fb9bdd05a4dc10fbb

softwarefactory-project-zuul · 2025-08-08T10:13:43Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4c4a41d1cce64b139e8bb431263c85ec

debarshiray force-pushed the wip/rishi/bkoropoff-kde-envvar branch from e7e040d to 610b291 Compare August 6, 2025 23:54

debarshiray force-pushed the wip/rishi/bkoropoff-kde-envvar branch from 610b291 to 6ef02da Compare August 7, 2025 13:07

debarshiray mentioned this pull request Aug 7, 2025

utils: preserve more KDE-related environment variables #1696

Open

debarshiray changed the title ~~pkg/utils: Preserve environment variables set by a KDE session~~ pkg/utils: Preserve environment variables set by a KDE session and Konsole Aug 7, 2025

debarshiray and others added 4 commits August 8, 2025 01:05

debarshiray force-pushed the wip/rishi/bkoropoff-kde-envvar branch from 157d7d6 to 1f12775 Compare August 7, 2025 23:09

debarshiray merged commit 39e0800 into containers:main Aug 8, 2025
3 checks passed

debarshiray deleted the wip/rishi/bkoropoff-kde-envvar branch August 8, 2025 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

pkg/utils: Preserve environment variables set by a KDE session and Konsole #1698

pkg/utils: Preserve environment variables set by a KDE session and Konsole #1698

Uh oh!

debarshiray commented Aug 6, 2025 •

edited

Loading

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

debarshiray commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

debarshiray commented Aug 8, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

pkg/utils: Preserve environment variables set by a KDE session and Konsole #1698

pkg/utils: Preserve environment variables set by a KDE session and Konsole #1698

Uh oh!

Conversation

debarshiray commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

debarshiray commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 7, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

debarshiray commented Aug 8, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

softwarefactory-project-zuul bot commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

debarshiray commented Aug 6, 2025 •

edited

Loading