Updated coffee chat suggestions script #1068
Conversation
|
|
|
[diff-counting] Significant lines: 140. |
|
|
||
| require('dotenv').config(); | ||
|
|
||
| import { configureAccount } from '../src/utils/firebase-utils'; |
There was a problem hiding this comment.
Would move this to the top of the file along with the other imports.
|
|
||
| import { configureAccount } from '../src/utils/firebase-utils'; | ||
|
|
||
| //const serviceAcc = require('../resources/cornelldti-idol-firebase-adminsdk-ifi28-9aaca97159.json'); |
There was a problem hiding this comment.
For comments, make sure to add a space after '//'
| .map((mem) => ({ name: `${mem.firstName} ${mem.lastName}`, netid: mem.netid })); | ||
|
|
||
| const getMembersByCategory = async () => { | ||
| //update csv path to current suggestions |
There was a problem hiding this comment.
Same suggestion here with the comments .
| const main = async () => { | ||
| const membersByCategory = await getMembersByCategory(); | ||
|
|
||
| const members = await memberPromise; |
There was a problem hiding this comment.
This looks really great Adrienne! I did notice that you fetch members both here and in the getMembersByCategory function (line 45). I would suggest passing members as a parameter instead to avoid redundant fetching. Otherwise, great job!
6 participants
Summary
Linear
coffee chat suggestions
Test plan
Note
I wanted to make a pr to merge the script since we would need to use it every semester (originally from Chris's branch).
Also right now, we need to manually check for members who make multiple submissions to the google form or submit their name in lowercase (generally just validate the data). Do we want to handle those cases in the script? Or since it's not too much work it's fine?