Update ring DynamoDB Client to write in a transaction when batching #6987
+227
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Tran <[email protected]>
Signed-off-by: Anna Tran <[email protected]>
Signed-off-by: Anna Tran <[email protected]>
| @@ -72,6 +72,7 @@ | |||
| * [ENHANCEMENT] API: add request ID injection to context to enable tracking requests across downstream services. #6895 | |||
| * [ENHANCEMENT] gRPC: Add gRPC Channelz monitoring. #6950 | |||
| * [ENHANCEMENT] Upgrade build image and Go version to 1.24.6. #6970 #6976 | |||
| * [ENHANCEMENT] Implement versioned transactions for batch writes to Ring DynamoDB. #6986 | |||
There was a problem hiding this comment.
nit: i would just say "for writes"
| putRequests[dynamodbKey{primaryKey: key, sortKey: childKey}] = bytes | ||
| putRequests[dynamodbKey{primaryKey: key, sortKey: childKey}] = dynamodbItem{ | ||
| data: bytes, | ||
| version: resp[childKey].version, |
There was a problem hiding this comment.
When we are adding an instance to the ring I dont think it will be on the resp from query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the DynamoDB ring client to use versioning in it's KV store entries. Specifically
dynamodbItemstruct which holds the data from the queried item along with a version. If there is no version from DynamoDB for the item, the version defaults to an empty string.Which issue(s) this PR fixes:
Fixes #6986
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]