Fix socket handle leak for outgoing TCP connections #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a proxy client sends a TCP_OPEN message while the proxy already has an open connection, the proxy will leak the handle to the original connection to process the new one. After testing this scenario on the Java implementation, it appears to send a TCP_CLOSE message to the client for the original connection and then immediately open a new connection. It's hard to tell if this is what the EchoLink client wants us to do, but taking the same behavior as the Java proxy is certainly better than leaking the handle like we were doing, so that's what this change does.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 51.67% 51.47% -0.20%
==========================================
Files 22 22
Lines 2901 2908 +7
==========================================
- Hits 1499 1497 -2
- Misses 1402 1411 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a proxy client sends a TCP_OPEN message while the proxy already has an open connection, the proxy will leak the handle to the original connection to process the new one.
After testing this scenario on the Java implementation, it appears to send a TCP_CLOSE message to the client for the original connection and then immediately open a new connection. It's hard to tell if this is what the EchoLink client wants us to do, but taking the same behavior as the Java proxy is certainly better than leaking the handle like we were doing, so that's what this change does.