Update github.com/shirou/gopsutil to v4 #7785
Open
+23
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the github.com/shirou/gopsutil dependency from v3 to v4 to take advantage of bug fixes and enhancements, particularly the removal of CGO implementations on Darwin.
- Updates gopsutil import paths from v3 to v4 across codebase
- Consolidates dependency management by removing duplicate v3 references
- Updates related transitive dependencies to compatible versions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rest/stats_context.go | Updates gopsutil import paths from v3 to v4 for net and cpu packages |
| rest/server_context.go | Updates gopsutil mem package import path to v4 |
| go.mod | Consolidates gopsutil dependencies to v4.25.8 and updates related transitive dependencies |
v4 is the latest version with bug fixes and enhancements, notably the removal of CGO implementations on Darwin in v4.24.9 [1]. Note: Due to the library's versioning policy, v4.24.5 is the first v4 release [2]. [1]: https://github.com/shirou/gopsutil/releases/tag/v4.24.9 [2]: https://github.com/shirou/gopsutil/releases/tag/v4.24.5 Signed-off-by: Eng Zer Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot missed updating this dependency. v4 is the latest version with bug fixes and enhancements, notably the removal of CGO implementations on Darwin in v4.24.9.
Note: Due to the library's versioning policy, v4.24.5 is the first v4 release. It introduces a few breaking changes, but we are not affected.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGatewayIntegration/0000/