Skip to content

RFC-0081: Add Columnar Streaming RFC #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DemetrisChr
Copy link
Contributor

No description provided.

programmatix
programmatix previously approved these changes Jan 21, 2025
dnault
dnault previously approved these changes Jan 22, 2025
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if I approve now or after the suggested changes to the sign-off are updated? 😅

dnault
dnault previously approved these changes Feb 4, 2025
@DemetrisChr
Copy link
Contributor Author

Dunno if I approve now or after the suggested changes to the sign-off are updated? 😅

I think we first need to get all the sign-offs, and once all of them have been committed, we can then get the PR approved (since GitHub discards any existing approvals with every commit/change)

@avsej avsej changed the title Add Columnar Streaming RFC RFC-0081: Add Columnar Streaming RFC Apr 2, 2025
@avsej avsej requested a review from emilienbev April 3, 2025 20:32
jeffrymorris
jeffrymorris previously approved these changes Apr 4, 2025
avsej
avsej previously approved these changes Apr 4, 2025
dnault
dnault previously approved these changes Apr 9, 2025
@DemetrisChr DemetrisChr dismissed stale reviews from dnault and avsej via c7bf3bf April 9, 2025 16:18
avsej
avsej previously approved these changes Apr 9, 2025
@avsej avsej requested a review from dnault April 10, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants