Skip to content

basic test for spaces and args #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wchristian
Copy link
Collaborator

This serves as a demonstration for the problems in #143.

As far as i understand IPC::Run and comments as #143 (comment) , all of the calls below should work on windows, right?

Because right now (as well as with older versions) it looks like only these succeed:

ipctest.bat
.\ipctest.bat
dirnospace\ipctest.bat
D:\cpan\IPC-Run\eg\ipctest.bat
D:\cpan\IPC-Run\eg\dirnospace\ipctest.bat
D:/cpan/IPC-Run/eg/ipctest.bat
D:/cpan/IPC-Run/eg/dirnospace/ipctest.bat

Notable failures:

  • spaces in dirs
  • spaces in executable
  • forward slashes in relative paths

Interestingly i was unable to reproduce the failure indicated by @stphnlyd in #143 (comment)

Note that i didn't yet consider the actual output of what's being run deeply, this mostly focuses on actually running it and getting basic arg behavior right. TODO: .exe files, .exe files with non-standard arg parsing, maybe more complicated args?

Comment invitation for @nmisch, @haarg, @toddr. (I think mohawk gets pinged automatically.)

run [ $_, "meep marp" ], ">", $out;

for all of

ipctest.bat
ipctest2 space.bat
.\ipctest.bat
./ipctest.bat
.\ipctest2 space.bat
./ipctest2 space.bat
dirnospace\ipctest.bat
dirnospace/ipctest.bat
dirnospace\ipctest2 space.bat
dirnospace/ipctest2 space.bat
dir space\ipctest.bat
dir space/ipctest.bat
dir space\ipctest2 space.bat
dir space/ipctest2 space.bat
D:\cpan\IPC-Run\eg\ipctest.bat
D:\cpan\IPC-Run\eg\ipctest2 space.bat
D:\cpan\IPC-Run\eg\dirnospace\ipctest.bat
D:\cpan\IPC-Run\eg\dirnospace\ipctest2 space.bat
D:\cpan\IPC-Run\eg\dir space\ipctest.bat
D:\cpan\IPC-Run\eg\dir space\ipctest2 space.bat
D:/cpan/IPC-Run/eg/ipctest.bat
D:/cpan/IPC-Run/eg/ipctest2 space.bat
D:/cpan/IPC-Run/eg/dirnospace/ipctest.bat
D:/cpan/IPC-Run/eg/dirnospace/ipctest2 space.bat
D:/cpan/IPC-Run/eg/dir space/ipctest.bat
D:/cpan/IPC-Run/eg/dir space/ipctest2 space.bat

@toddr
Copy link
Member

toddr commented Aug 10, 2022

Can you rebase this please?

@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 11, 2022

I like the concept! I do think it would be better to capture all the tested files into a module and generate them in a tempdir, in a similar style to EUMM's https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/blob/master/t/lib/MakeMaker/Test/Setup/XS.pm

@nmisch nmisch added the stalled Waiting for response from ticket creator. label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Waiting for response from ticket creator.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants