-
Notifications
You must be signed in to change notification settings - Fork 5
Support full TOC from a project and use for Guides project. #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ca2ab37
Remove Guides heading from sidebar
bmunkholm e72f24d
CSS for unindenting TOC entries
bmunkholm 3f9fee1
Fix CSS
bmunkholm e833457
add documentation about testing
bmunkholm d9f49ed
Updated Changes.rst
bmunkholm 432f664
Merge branch 'main' into bm/move-getting-started-1
bmunkholm 50e7124
rename guide to handbook
bmunkholm d8aa4d3
temporary dev1 version
bmunkholm aea4070
Merge branch 'bm/move-getting-started-1' of https://github.com/crate/…
bmunkholm c29794a
Revert the version change - will be done separately.
bmunkholm b6ef0e5
Merge branch 'main' of https://github.com/crate/crate-docs-theme into…
bmunkholm 926c427
Merge branch 'bm/move-getting-started-1' of https://github.com/crate/…
bmunkholm 5f48c16
Special handling of root page
bmunkholm 65622a9
fix comment
bmunkholm 6c984be
Merge remote-tracking branch 'origin/main' into bm/move-getting-start…
bmunkholm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking again about my previous request: Maybe this can be adjusted to just point to
guide/
again. Does anything speak against it?The relocation caused a problem:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are probably right in your assessment that this won't work as requested. Maybe try again? Otherwise we may find a different solution for mitigating the blank page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that not require that the handbook/index.md file is placed in the root where we currently have the index file that contains the 3 toplevel toc entries? Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably the dilemma? Or just re-add the main body content there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I was considering the same anyway as it's more clean. It just required a bit of special handling to ensure that the Overview page is selected/bolded initially. Fixed now.