-
-
Notifications
You must be signed in to change notification settings - Fork 194
WIP - Support thinking mode for Anthropic models #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rhys117
wants to merge
21
commits into
crmne:main
Choose a base branch
from
rhys117:154-thinking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
81ed712
feat: wip - add thinking content to messages
rhys117 a47870a
Merge branch 'main' into 154-thinking
rhys117 b6e1bb0
chore: add thinking to capabilities
rhys117 ecb69c9
chore: pass thinking through from chat initialisation
rhys117 a014b77
chore: add very basic config for thinking budget through global confi…
rhys117 ddb0ae1
bug: fix config missing comma
rhys117 6d66491
chore: add streaming content
rhys117 7da672e
chore: rename to use existing reasoning capability
rhys117 c948b0e
Merge branch 'main' into 154-thinking
rhys117 6b4fb83
chore: rename to thinking
rhys117 7ec6733
Get thinking working with bedrock
hiemanshu 8709018
Merge branch 'main' into 154-thinking
crmne b8fb932
Merge pull request #1 from recitalsoftware/154-thinking
rhys117 5577bae
chore: update anthropic capabilities with thinking
rhys117 5c02af2
chore: move temperature setting to param
rhys117 153440c
chore: use 'thinking' capability instead of reasoning in Model::Info
rhys117 627ffe0
chore: allow thinking capabilties on assumed models
rhys117 8a6453d
bug: fix call to check if thinking supported in 'with_thinking'
rhys117 cc1ce5f
test: add basic spec for anthropic models
rhys117 87fa6a5
Merge branch 'main' into 154-thinking
rhys117 06daa1c
bug: ensure render_payload args compatibility across all providers
rhys117 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,9 @@ def initialize(model: nil, provider: nil, assume_model_exists: false, context: n | |
@config = context&.config || RubyLLM.config | ||
model_id = model || @config.default_model | ||
with_model(model_id, provider: provider, assume_exists: assume_model_exists) | ||
@temperature = 0.7 | ||
@thinking = @config.default_thinking | ||
@thinking_budget = @config.default_thinking_budget | ||
@temperature = @config.default_temperature | ||
@messages = [] | ||
@tools = {} | ||
@on = { | ||
|
@@ -63,6 +65,8 @@ def with_tools(*tools) | |
def with_model(model_id, provider: nil, assume_exists: false) | ||
@model, @provider = Models.resolve(model_id, provider:, assume_exists:) | ||
@connection = @context ? @context.connection_for(@provider) : @provider.connection(@config) | ||
# TODO: Currently the unsupported errors will not retrigger after model reassignment. | ||
|
||
self | ||
end | ||
|
||
|
@@ -71,6 +75,18 @@ def with_temperature(temperature) | |
self | ||
end | ||
|
||
def with_thinking(thinking: true, budget: nil, temperature: 1) | ||
raise UnsupportedThinkingError, "Model #{@model.id} doesn't support thinking" if thinking && [email protected]? | ||
|
||
@thinking = thinking | ||
|
||
# Most thinking models require set temperature so force it 1 here, however allowing override via param. | ||
@temperature = temperature | ||
@thinking_budget = budget if budget | ||
|
||
self | ||
end | ||
|
||
def with_context(context) | ||
@context = context | ||
@config = context.config | ||
|
@@ -98,6 +114,8 @@ def complete(&) | |
tools: @tools, | ||
temperature: @temperature, | ||
model: @model.id, | ||
thinking: @thinking, | ||
thinking_budget: @thinking_budget, | ||
connection: @connection, | ||
&wrap_streaming_block(&) | ||
) | ||
|
@@ -123,6 +141,10 @@ def reset_messages! | |
@messages.clear | ||
end | ||
|
||
def thinking? | ||
@thinking | ||
end | ||
|
||
private | ||
|
||
def wrap_streaming_block(&block) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ def completion_url | |
"models/#{@model}:generateContent" | ||
end | ||
|
||
def render_payload(messages, tools:, temperature:, model:, stream: false) # rubocop:disable Lint/UnusedMethodArgument | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Discarding unused params using '**' is my preference here, but would be keen to hear others' opinions here please |
||
def render_payload(messages, tools:, temperature:, model:, **) | ||
@model = model # Store model for completion_url/stream_url | ||
payload = { | ||
contents: format_messages(messages), | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
default_temperature
doesn't exist:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been corrected, thanks to @hiemanshu