feat(pgsql): extend Grant kind specification with schema, tables, columns, sequences, routines, foreign data wrappers, foreign servers

[Sabotaz]

Description of your changes

Fixes #217

This PR is a rework of #218 who is still a draft and will probably be closed soon by his owner (cf. comments).

This PR create more fields in the forProvider part of the Grant kind for managing grants on different objects.

I refactored #218 by removing the defined objectType and objects fields, and using specific fields for each type of grant. I believe it follows the original philosophy of the Grant kind better.

This PR does not cover the GRANT xxx ON ALL xxx IN SCHEMA yyy case.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable to ensure this PR is ready for review.

How has this code been tested

I tested this PR using both make test and make e2e.
I tested the raw queries on my local database.

e2e tests & unit tests have been updated with more Grant configurations :

• grant some privileges on schema
• grant some privileges on 1 table
• grant some privileges on 1 column of 1 table
• grant some privileges on 1 routine
• grant some privileges on 1 sequence
• grant some privileges on 1 foreign data wrapper
• grant some privileges on 1 foreign server

However, I have only tested requests for multiple objets (i.e: grant all on table1, table2 to user ) on my local database.

I did not test this PR against sql injections, as I believe it is already a problem for the actual Grant feature (see #18 , #22 for mysql, and I would say #22 did not fully fix the problem for mysql as the injection can still be performed using some other fields: database, table, user).

[Sabotaz]

@Duologic, can anyone among the maintainers review this PR?
@Bastichou as you already worked on this issue, perhaps you can review it too? :D

[dawidmalina]

Adding @chlunde to the loop - this change is really needed by many Postgres users

[dawidmalina]

Just tested and I can confirmed that I can achieve GRANT USAGE, CREATE ON SCHEMA public TO <ROLE>; with crossplane:

---
apiVersion: postgresql.sql.crossplane.io/v1alpha1
kind: Grant
metadata:
  name: public
spec:
  forProvider:
    databaseRef:
      name: <DATABASE>
    privileges:
      - CREATE
      - USAGE
    roleRef:
      name: <ROLE>
    schema: public
  providerConfigRef:
    name: admin

Looking forward to use official provider not custom build.

[chlunde]

@dawidmalina thanks for testing!

If we have consensus on the schema design, I think that (and testing) is most important.

Linewise, the change is huge (+2000 lines), so getting a few eyes on this would be very helpful.

[dawidmalina]

Any updates on this? I would really like to see that to be part of the official release.

[chlunde]

@Bastichou could you take a look at this version?

I've read through all the issues and closed duplicates, and I think this solves a lot of them. I'd like to make this part of the next release, so thanks a lot for everyone working on this!

Two things I would like to test:

• That this is 100% compatible with existing grants
• That we're sure this is the right design

This PR does not cover the GRANT xxx ON ALL xxx IN SCHEMA yyy case.

@Sabotaz do you think this could be handled in the future, could you expand a bit on this? Thanks!

[Kidswiss]

That we're sure this is the right design

Can you elaborate what design you mean? The CRD design? Code design?