-
Notifications
You must be signed in to change notification settings - Fork 31
Merge frontend improvements #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nadrieril
wants to merge
55
commits into
cryspen:main
Choose a base branch
from
Nadrieril:upstream-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the special `ImplExpr::SelfImpl` is only valid within a trait declaration.
They weren't used anywhere. This also removes `IsState` which was an union of these traits.
In preparation for being able to insert new clauses after initial construction.
It's redundant, we already have this information in `DefId`.
This makes monomorphization harder
This was referenced Jul 22, 2025
Closed
Wow, thank you, that's a lot of work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I made to the frontend for the purposes of Charon over the last few weeks. In rough order, the changes looks like:
Self: Trait
clause to trait methods and consts (replaces Add an explicitSelf: Trait
clause to trait assoc items #1541);ImplExpr::Builtin
that had some type errors (replaces FixImplExpr::Builtin
#1543);Drop
information;State
infrastructure a little bit (this is opinionated, you might disagree);dyn Trait
predicates;FullDef
;FullDef
; this is used in charon to monomorphize a crate graph.I fixed
import_thir.ml
but not all the engine tests pass. I'll leave that to you.The branch consists of a merge of about 10 branches that each could have been a PR; you can review merge-commit-by-merge-commit if you want, the bullet points above would be roughly the PR titles.