Skip to content

Limit photo album visibility #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 40 commits into
base: staging
Choose a base branch
from
Draft

Conversation

wilco375
Copy link
Contributor

@wilco375 wilco375 commented Mar 12, 2022

Fixes issue #383

@wilco375 wilco375 marked this pull request as draft July 2, 2023 11:04
@lodewiges lodewiges marked this pull request as ready for review February 4, 2025 11:34
@lodewiges
Copy link
Contributor

lodewiges commented Feb 4, 2025

It could be an idea to add a button just like publicly visible for visibility for oudleden. for example, if we have an activity where oudleden are invited. It would also be usefull to look into how this affects the suggestions for phototagging on the SOG page

@lodewiges lodewiges marked this pull request as draft February 4, 2025 12:50
@wilco375
Copy link
Contributor Author

wilco375 commented Feb 4, 2025

It could be an idea to add a button just like publicly visible for visibility for oudleden. for example, if we have an activity where oudleden are invited. It would also be usefull to look into how this affects the suggestions for phototagging on the SOG page

Might be good to add this in addition to comparison of membership date yeah! Then old members can see all photos from their membership and relevant activities from after their membership.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (14502d6) to head (d91f320).
Report is 4 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #286      +/-   ##
===========================================
- Coverage    99.92%   99.92%   -0.01%     
===========================================
  Files          197      197              
  Lines         2662     2659       -3     
===========================================
- Hits          2660     2657       -3     
  Misses           2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lodewiges lodewiges force-pushed the feature/limit-photo-visibility branch from 805b24e to 12adbf9 Compare March 3, 2025 16:51
@lodewiges
Copy link
Contributor

lodewiges commented Mar 17, 2025

okay so the tests are not outputting consistent results, sometimes they pass, sometimes they dont
besides that more tests should be written before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants