chore(deps): update dependency rails to v8

.rubocop.yml

@@ -6,7 +6,7 @@ plugins:
   - rubocop-rspec_rails
 
 AllCops:
-  TargetRailsVersion: 7.1
+  TargetRailsVersion: 8.0
   TargetRubyVersion: 3.3
   Exclude:
     - 'db/schema.rb'

Gemfile

@@ -30,8 +30,8 @@ gem 'puma', '~> 6.6'
 gem 'pundit', '~> 2.5'
 gem 'rack-attack', '~> 6.7'
 gem 'rack-cors', '~> 2.0', '>= 2.0.2', require: 'rack/cors'
-gem 'rails', '~> 7.1.5', '>= 7.1.5.1'
-gem 'rails-i18n', '~> 7.0', '>= 7.0.10'
+gem 'rails', '~> 8.0', '>= 8.0.1'
+gem 'rails-i18n', '~> 8.0', '>= 8.0.0'
 gem 'redis', '~> 5.4'
 gem 'roo', '~> 2.10', '>= 2.10.1'
 gem 'ruby-filemagic', '~> 0.7', '>= 0.7.3'
@@ -42,7 +42,7 @@ gem 'sentry-sidekiq', '~> 5.23'
 gem 'sepa_king', '~> 0.14'
 gem 'sidekiq', '~> 7.3', '>= 7.3.9'
 gem 'sidekiq-scheduler', '~> 5.0', '>= 5.0.6'
-gem 'validates_timeliness', '~> 7.1.0'
+gem 'validates_timeliness', '~> 8.0.0'
 gem 'vpim', '~> 24.2', '>= 24.2.20'
 
 group :development, :test do

Gemfile.lock

@@ -1,86 +1,80 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actioncable (8.0.1)
+      actionpack (= 8.0.1)
+      activesupport (= 8.0.1)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
       zeitwerk (~> 2.6)
-    actionmailbox (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (>= 2.7.1)
-      net-imap
-      net-pop
-      net-smtp
-    actionmailer (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (~> 2.5, >= 2.5.4)
-      net-imap
-      net-pop
-      net-smtp
+    actionmailbox (8.0.1)
+      actionpack (= 8.0.1)
+      activejob (= 8.0.1)
+      activerecord (= 8.0.1)
+      activestorage (= 8.0.1)
+      activesupport (= 8.0.1)
+      mail (>= 2.8.0)
+    actionmailer (8.0.1)
+      actionpack (= 8.0.1)
+      actionview (= 8.0.1)
+      activejob (= 8.0.1)
+      activesupport (= 8.0.1)
+      mail (>= 2.8.0)
       rails-dom-testing (~> 2.2)
-    actionpack (7.1.5.1)
-      actionview (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionpack (8.0.1)
+      actionview (= 8.0.1)
+      activesupport (= 8.0.1)
       nokogiri (>= 1.8.5)
-      racc
       rack (>= 2.2.4)
       rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    actiontext (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+      useragent (~> 0.16)
+    actiontext (8.0.1)
+      actionpack (= 8.0.1)
+      activerecord (= 8.0.1)
+      activestorage (= 8.0.1)
+      activesupport (= 8.0.1)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionview (8.0.1)
+      activesupport (= 8.0.1)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
     active_model_otp (2.3.4)
       activemodel
       rotp (~> 6.3.0)
-    activejob (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activejob (8.0.1)
+      activesupport (= 8.0.1)
       globalid (>= 0.3.6)
-    activemodel (7.1.5.1)
-      activesupport (= 7.1.5.1)
-    activerecord (7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activemodel (8.0.1)
+      activesupport (= 8.0.1)
+    activerecord (8.0.1)
+      activemodel (= 8.0.1)
+      activesupport (= 8.0.1)
       timeout (>= 0.4.0)
-    activestorage (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activestorage (8.0.1)
+      actionpack (= 8.0.1)
+      activejob (= 8.0.1)
+      activerecord (= 8.0.1)
+      activesupport (= 8.0.1)
       marcel (~> 1.0)
-    activesupport (7.1.5.1)
+    activesupport (8.0.1)
       base64
       benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
       logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
       securerandom (>= 0.3)
-      tzinfo (~> 2.0)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.3)
@@ -92,9 +86,10 @@ GEM
     better_errors (2.10.1)
       erubi (>= 1.0.0)
       rack (>= 0.9.0)
-      rouge (>= 1.0.0)
     bigdecimal (3.1.9)
     bigdecimal (3.1.9-java)
+    binding_of_caller (1.0.1)
+      debug_inspector (>= 1.2.0)
     binding_of_caller (1.0.1)
       debug_inspector (>= 1.2.0)
     bootsnap (1.18.4)
@@ -273,7 +268,6 @@ GEM
     minitest (5.25.5)
     msgpack (1.8.0)
     msgpack (1.8.0-java)
-    mutex_m (0.3.0)
     nenv (0.3.0)
     net-imap (0.5.6)
       date
@@ -355,34 +349,34 @@ GEM
       rack (>= 1.3)
     rackup (2.2.1)
       rack (>= 3)
-    rails (7.1.5.1)
-      actioncable (= 7.1.5.1)
-      actionmailbox (= 7.1.5.1)
-      actionmailer (= 7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actiontext (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    rails (8.0.1)
+      actioncable (= 8.0.1)
+      actionmailbox (= 8.0.1)
+      actionmailer (= 8.0.1)
+      actionpack (= 8.0.1)
+      actiontext (= 8.0.1)
+      actionview (= 8.0.1)
+      activejob (= 8.0.1)
+      activemodel (= 8.0.1)
+      activerecord (= 8.0.1)
+      activestorage (= 8.0.1)
+      activesupport (= 8.0.1)
       bundler (>= 1.15.0)
-      railties (= 7.1.5.1)
+      railties (= 8.0.1)
     rails-dom-testing (2.2.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.6.2)
       loofah (~> 2.21)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    rails-i18n (7.0.10)
+    rails-i18n (8.0.1)
       i18n (>= 0.7, < 2)
-      railties (>= 6.0.0, < 8)
-    railties (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      irb
+      railties (>= 8.0.0, < 9)
+    railties (8.0.1)
+      actionpack (= 8.0.1)
+      activesupport (= 8.0.1)
+      irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
@@ -432,7 +426,6 @@ GEM
       nokogiri (~> 1)
       rubyzip (>= 1.3.0, < 3.0.0)
     rotp (6.3.0)
-    rouge (4.5.1)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -552,8 +545,10 @@ GEM
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     uniform_notifier (1.16.0)
-    validates_timeliness (7.1.0)
-      activemodel (>= 7.0.0, < 8)
+    uri (1.0.2)
+    useragent (0.16.11)
+    validates_timeliness (8.0.0)
+      activemodel (>= 8.0.0, < 9)
       timeliness (>= 0.3.10, < 1)
     vcr (6.3.1)
       base64
@@ -626,8 +621,8 @@ DEPENDENCIES
   rack-attack (~> 6.7)
   rack-cors (~> 2.0, >= 2.0.2)
   rack-mini-profiler (~> 3.3, >= 3.3.1)
-  rails (~> 7.1.5, >= 7.1.5.1)
-  rails-i18n (~> 7.0, >= 7.0.10)
+  rails (~> 8.0, >= 8.0.1)
+  rails-i18n (~> 8.0, >= 8.0.0)
   rb-readline (~> 0.5, >= 0.5.5)
   redis (~> 5.4)
   roo (~> 2.10, >= 2.10.1)
@@ -654,7 +649,7 @@ DEPENDENCIES
   terminal-notifier-guard (~> 1.7)
   timecop (~> 0.9, >= 0.9.10)
   tzinfo-data
-  validates_timeliness (~> 7.1.0)
+  validates_timeliness (~> 8.0.0)
   vcr (~> 6.3, >= 6.3.1)
   vpim (~> 24.2, >= 24.2.20)
   webmock (~> 3.25, >= 3.25.1)

app/models/debit/mandate.rb

@@ -20,15 +20,18 @@ class Mandate < ApplicationRecord
 
     private
 
-    def unique_on_time_interval?
-      return true unless Debit::Mandate.where.not(id:).where(user_id:)
-                                       .exists?([':start_date BETWEEN start_date AND end_date OR
-                                        :end_date BETWEEN start_date AND end_date OR
-                                        start_date BETWEEN :start_date AND :end_date OR
-                                        end_date BETWEEN :start_date AND :end_date OR
-                                        (start_date < :start_date AND end_date IS NULL) OR
-                                        (start_date > :start_date AND :end_date IS NULL)',
-                                                 { start_date:, end_date: }])
+    def unique_on_time_interval? # rubocop:disable Metrics/MethodLength
+      return true unless Debit::Mandate.where.not(id:)
+                                       .where(user_id:)
+                                       .exists?([<<-SQL.squish, { start_date: start_date, end_date: end_date }])
+
+          CAST(:start_date AS date) BETWEEN start_date AND end_date OR
+          CAST(:end_date AS date) BETWEEN start_date AND end_date OR
+          start_date BETWEEN CAST(:start_date AS date) AND CAST(:end_date AS date) OR
+          end_date BETWEEN CAST(:start_date AS date) AND CAST(:end_date AS date) OR
+          (start_date < CAST(:start_date AS date) AND end_date IS NULL) OR
+          (start_date > CAST(:start_date AS date) AND CAST(:end_date AS date) IS NULL)
+                                       SQL
 
       errors.add(:mandate, 'is not unique on time interval')
       false

app/models/import/user.rb

@@ -1,6 +1,7 @@
 module Import
   class User
     extend ActiveRecord::Translation
+    include ActiveModel::Model
     include SpreadsheetHelper
 
     attr_reader :errors, :imported_users

app/models/membership.rb

@@ -19,15 +19,18 @@ class Membership < ApplicationRecord
 
   private
 
-  def unique_on_time_interval?
-    return true unless Membership.where.not(id:).where(group_id:, user_id:)
-                                 .exists?([':start_date BETWEEN start_date AND end_date OR
-                                        :end_date BETWEEN start_date AND end_date OR
-                                        start_date BETWEEN :start_date AND :end_date OR
-                                        end_date BETWEEN :start_date AND :end_date OR
-                                        (start_date < :start_date AND end_date IS NULL) OR
-                                        (start_date > :start_date AND :end_date IS NULL)',
-                                           { start_date:, end_date: }])
+  def unique_on_time_interval? # rubocop:disable Metrics/MethodLength
+    return true unless Membership.where.not(id:)
+                                 .where(group_id:, user_id:)
+                                 .exists?([<<-SQL.squish, { start_date: start_date, end_date: end_date }])
+
+      CAST(:start_date AS date) BETWEEN start_date AND end_date OR
+      CAST(:end_date AS date) BETWEEN start_date AND end_date OR
+      start_date BETWEEN CAST(:start_date AS date) AND CAST(:end_date AS date) OR
+      end_date BETWEEN CAST(:start_date AS date) AND CAST(:end_date AS date) OR
+      (start_date < CAST(:start_date AS date) AND end_date IS NULL) OR
+      (start_date > CAST(:start_date AS date) AND CAST(:end_date AS date) IS NULL)
+                                 SQL
 
     errors.add(:membership, 'is not unique on time interval')
     false

bin/brakeman

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+require 'rubygems'
+require 'bundler/setup'
+
+ARGV.unshift('--ensure-latest')
+
+load Gem.bin_path('brakeman', 'brakeman')

bin/rubocop

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+require 'rubygems'
+require 'bundler/setup'
+
+# explicit rubocop config increases performance slightly while avoiding config confusion.
+ARGV.unshift('--config', File.expand_path('../.rubocop.yml', __dir__))
+
+load Gem.bin_path('rubocop', 'rubocop')

bin/setup

@@ -30,4 +30,8 @@ FileUtils.chdir APP_ROOT do
 
   puts "\n== Restarting application server =="
   system! 'bin/rails restart'
+
+  # puts "\n== Configuring puma-dev =="
+  # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}"
+  # system "curl -Is https://#{APP_NAME}.test/up | head -n 1"
 end

config/application.rb

@@ -1,4 +1,5 @@
 require_relative 'boot'
+# Pick the frameworks you want:
 require 'rails'
 require 'active_model/railtie'
 require 'active_job/railtie'
@@ -7,7 +8,10 @@
 require 'action_controller/railtie'
 require 'action_mailer/railtie'
 require 'action_mailbox/engine'
-# require "action_view/railtie"
+# require 'action_text/engine'
+# require 'action_view/railtie'
+# require 'action_cable/engine'
+# require 'rails/test_unit/railtie'
 
 # Require the gems listed in Gemfile, including any gems
 # you've limited to :test, :development, or :production.
@@ -18,7 +22,6 @@ class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
     config.load_defaults 7.1
 
-    config.add_autoload_paths_to_load_path = false
     # Please, add to the `ignore` list any other `lib` subdirectories that do
     # not contain `.rb` files, or that should not be reloaded or eager loaded.
     # Common ones are `templates`, `generators`, or `middleware`, for example.