-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add datasource schema read methods #9818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MikeNitsenko
merged 25 commits into
master
from
feat-add-datasource-schema-read-methods
Jul 29, 2025
Merged
feat: add datasource schema read methods #9818
MikeNitsenko
merged 25 commits into
master
from
feat-add-datasource-schema-read-methods
Jul 29, 2025
+622
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4757236
to
5e0b699
Compare
ovr
reviewed
Jul 28, 2025
packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts
Outdated
Show resolved
Hide resolved
ovr
reviewed
Jul 28, 2025
packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts
Outdated
Show resolved
Hide resolved
434a5e2
to
6685b6c
Compare
ovr
reviewed
Jul 29, 2025
packages/cubejs-query-orchestrator/test/unit/QueryOrchestrator.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new data source metadata query methods to the QueryOrchestrator, enabling retrieval of schemas, tables, and columns through cached query operations.
Key changes:
- Adds three new public methods for querying metadata:
queryDataSourceSchemas
,queryTablesForSchemas
, andqueryColumnsForTables
- Implements caching support for metadata operations with configurable refresh options
- Extends QueryCache to handle metadata-specific operations through a new query handler
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts | Adds metadata query methods and operation types with caching support |
packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts | Implements metadata query handler and cancel handler for the queue system |
packages/cubejs-query-orchestrator/test/unit/QueryOrchestrator.test.js | Adds comprehensive test suite covering all metadata methods and integration scenarios |
packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts
Outdated
Show resolved
Hide resolved
packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts
Outdated
Show resolved
Hide resolved
ovr
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List