Skip to content

feat: add datasource schema read methods #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 29, 2025

Conversation

MikeNitsenko
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jul 25, 2025
@MikeNitsenko MikeNitsenko force-pushed the feat-add-datasource-schema-read-methods branch from 4757236 to 5e0b699 Compare July 28, 2025 08:29
@MikeNitsenko MikeNitsenko marked this pull request as ready for review July 28, 2025 12:54
@MikeNitsenko MikeNitsenko requested a review from a team as a code owner July 28, 2025 12:55
@MikeNitsenko MikeNitsenko requested review from KSDaemon and ovr July 28, 2025 12:55
@MikeNitsenko MikeNitsenko force-pushed the feat-add-datasource-schema-read-methods branch from 434a5e2 to 6685b6c Compare July 28, 2025 15:51
@MikeNitsenko MikeNitsenko requested a review from ovr July 29, 2025 11:52
@ovr ovr requested a review from Copilot July 29, 2025 13:02
Copilot

This comment was marked as outdated.

@MikeNitsenko MikeNitsenko requested review from ovr and Copilot July 29, 2025 13:35
Copilot

This comment was marked as outdated.

@MikeNitsenko MikeNitsenko requested a review from Copilot July 29, 2025 13:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new data source metadata query methods to the QueryOrchestrator, enabling retrieval of schemas, tables, and columns through cached query operations.

Key changes:

  • Adds three new public methods for querying metadata: queryDataSourceSchemas, queryTablesForSchemas, and queryColumnsForTables
  • Implements caching support for metadata operations with configurable refresh options
  • Extends QueryCache to handle metadata-specific operations through a new query handler

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts Adds metadata query methods and operation types with caching support
packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts Implements metadata query handler and cancel handler for the queue system
packages/cubejs-query-orchestrator/test/unit/QueryOrchestrator.test.js Adds comprehensive test suite covering all metadata methods and integration scenarios

@MikeNitsenko MikeNitsenko merged commit 8fd6dcc into master Jul 29, 2025
67 checks passed
@MikeNitsenko MikeNitsenko deleted the feat-add-datasource-schema-read-methods branch July 29, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants