Skip to content

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Sep 28, 2025

🤔 What's changed?

Updated how license metadata is specified in pyproject.toml file

⚡️ What's your motivation?

Be compliant with PEP639

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes the smell test, but haven't read PEP639. I'll defer that to @kieran-ryan .

@mpkorstanje
Copy link
Contributor

@kieran-ryan is this good to merge now?

@kieran-ryan
Copy link
Member

kieran-ryan commented Oct 8, 2025

@kieran-ryan is this good to merge now?

@mpkorstanje gonna verify locally tonight… just to ensure is packaging artifacts as before 👍

@kieran-ryan kieran-ryan merged commit 32789f8 into cucumber:main Oct 10, 2025
3 checks passed
Copy link
Member

@kieran-ryan kieran-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants