Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useGasInfoAndUpdateLib({ chainId, networks })
in the layouts of all dapps. In other words, instead of having gas updates sprinkled everywhere, we now have 4 major hook usages on the top level of each app keeping gas info fresh.curve.setCustomFeeData()
when it fetches gas info. This is not ideal and we'd want to keep queries side-effect free. But I think that refactor is out of scope. I've extensively documented this in comments above the query'squeryFactory
call. I've also named the queryuseGasInfoAndUpdateLib
with a specificAndUpdateLib
part to specify this behavior. A later PR / ticket can be made to extract this side-effect and put it in a properuseEffect
on the layout level of the apps.