forked from cvxpy/cvxpy
-
Notifications
You must be signed in to change notification settings - Fork 0
adding example from pricing problem (from max) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Transurgeon
wants to merge
5
commits into
master
Choose a base branch
from
max-pricing-example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks that have improved:
Benchmarks that have stayed the same:
|
Transurgeon
commented
Oct 16, 2025
Comment on lines
+270
to
+275
rows, cols, vals = grad_dict[var] | ||
grad = sp.coo_matrix((vals, (rows, cols)), shape=(1, size)) | ||
vals = grad.T | ||
if sp.issparse(vals): | ||
vals = vals.toarray().flatten(order='F') | ||
self.grad_obj[grad_offset:grad_offset+size] = vals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep these changes so that we don't rely on cvxpy's grad functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a short summary of the change.
IPOPT converges to the same optimal solution as max's CCP method, but quite a bit faster.
Issue link (if applicable):
Type of change
Contribution checklist