internal: updating studio-server initialization with renderer APIs #32204
+335
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
tbiethman/studio-ai-visibility
|
| Run status |
|
| Run duration | 09m 35s |
| Commit |
|
| Committer | Tyler Biethman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
694
|
Skipped
|
0
|
Passing
|
130
|
| View all changes introduced in this branch ↗︎ | |
…arallelizing browser state reset during studio initialization
| this._studioElectron = new StudioElectron() | ||
| } | ||
|
|
||
| await this.invokeAsync('initializeStudioAI', { isEssential: true }, { |
There was a problem hiding this comment.
Nice. I like how this is tied to AI initialization now.
ryanthemanuel
approved these changes
Aug 14, 2025
…tbiethman/studio-ai-visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Open to suggestions on the electron dependency - I didn't think it was worth it to plumb the BrowserWindow class through the DataContext somehow but I think we could do that.
Also taking a look at any integration-level testing we have around this.
Steps to test
Test in conjunction with equivalent services branch - reach out for more details.
How has the user experience changed?
No user-facing changes here
PR Tasks
cypress-documentation?type definitions?