Skip to content

internal: Update reporter stats and controls styles #32207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 18, 2025

Conversation

chrisbreiding
Copy link
Contributor

Additional details

Updates reporter stats and controls styles per the design.

Open Testing Preferences hover style

Screenshot 2025-08-12 at 1 40 49 PM

Rerun hover style

Screenshot 2025-08-12 at 1 40 58 PM

Resume hover style while paused

Screenshot 2025-08-12 at 1 41 08 PM

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Aug 12, 2025

cypress    Run #64700

Run Properties:  status check passed Passed #64700  •  git commit 38446f8838: Merge remote-tracking branch 'origin/develop' into chrisbreiding/11111-reporter-...
Project cypress
Branch Review chrisbreiding/11111-reporter-header-styles
Run status status check passed Passed #64700
Run duration 19m 35s
Commit git commit 38446f8838: Merge remote-tracking branch 'origin/develop' into chrisbreiding/11111-reporter-...
Committer Chris Breiding
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 16
Tests that did not run due to a developer annotating a test with .skip  Pending 1101
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26552
View all changes introduced in this branch ↗︎
UI Coverage  45.27%
  Untested elements 186  
  Tested elements 158  
Accessibility  97.71%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

Copy link
Contributor

@mabela416 mabela416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test name and duration for the studio view is not centered anymore. See percy
image

@chrisbreiding
Copy link
Contributor Author

The test name and duration for the studio view is not centered anymore. See percy

@mabela416 Fixed in da572a8

Screenshot 2025-08-13 at 12 04 22 PM

Copy link
Contributor

@mabela416 mabela416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So design wanted this status icon to remain on top when the test name was too long so that's why the align-items was flex-start and then the icon had some margin so it could be at the right position with the start of the text
image

How it's supposed to look
image

@chrisbreiding
Copy link
Contributor Author

@mabela416 I think I got it as good as it's going to get in 6ef9bc1. The taller icons make it a little weird once the test title wraps.

Screenshot 2025-08-14 at 9 14 13 AM Screenshot 2025-08-14 at 9 14 23 AM

@mabela416
Copy link
Contributor

@chrisbreiding It looks good. Could you please add a percy snapshot with a super long test name so that we catch this in the future if we make changes to the styles

@chrisbreiding
Copy link
Contributor Author

Could you please add a percy snapshot with a super long test name so that we catch this in the future if we make changes to the styles

@mabela416 Added in 164454d

@chrisbreiding chrisbreiding merged commit 4bb6f7b into develop Aug 18, 2025
84 of 90 checks passed
@chrisbreiding chrisbreiding deleted the chrisbreiding/11111-reporter-header-styles branch August 18, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants