-
Notifications
You must be signed in to change notification settings - Fork 3.3k
breaking: update execa from 1.0.0 to 4.1.0 #32238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36845c8
to
6b32754
Compare
6b32754
to
3f3cb40
Compare
3f3cb40
to
ae3ce33
Compare
ae3ce33
to
2a57abb
Compare
|
cypress-io/cypress-example-kitchensink#984 has been merged and so now [email protected] has been released and the npm registry is showing it as published:
It probably makes sense to bump |
2a57abb
to
4c0c949
Compare
It looks like you're running CircleCI against your closed PR
Probably you'll need to bump that one ... to test it properly against what is published. |
ah thanks for reminding me! Going to make sure the windows jobs pass first |
the non kitchensink ones obviously 😂 |
…y.exec() object from yielding property code and instead yields exitCode
142b451
to
d7079e3
Compare
Hopefully you'll be able to get the Windows tests running soon. If not, then I'd suggest putting in an interim PR which ties the kitchensink tests back to an earlier PR cypress-io/cypress-example-kitchensink#978 before the |
@MikeMcC399 the windows build are passing. Currently fixing a broken |
I'd like to test the
Can you recommend a working |
@MikeMcC399 is the binary still 404ing for you? |
Unfortunately yes. This issue also cropped up during the 14.5.3 release (non beta binary). Cloudflare cache believes the file doesn't exist, but if I bust the cache by appending an arbitrary query to the URL then it is able to find the zip file.
|
@MikeMcC399 I just purged the zip url from the Cloudflare cache. Are you able to try now? |
Many thanks for the cache purge! I was able to load this into a Cypress Docker image and successfully test with it in a Cypress Docker repo clone. So I'd expect a Cypress 15 release also to pass the test-project tests when that event happens. BTW: All of the newer beta linux-x64 zip files give 404. I don't actually need them, but I just wanted to mention it. If you think I should open a separate issue for this please let me know. |
@MikeMcC399 this is unfortunately a persistent problem. We've talked about it as a team and would like to automate the cache clearing at some point. I can't remember if there is an issue for it or not, but it is on our radar. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Updating execa from 1.0.0 to 4.x in the
data-context
andserver
packages, 1.0.0 was released on Nov 12, 2018.The main breaking changes relevant to us:
execa.shell()
andexeca.shellSync()
sindresorhus/execa#219)error.code
sindresorhus/execa#250)Some of this code in the
data-context
package likely never functioned correctly. ThisexitCode
does not exist on 1.0.0 of execa, it was added in 2.0.0, so I think this code path would never have run.Also, since
code
changed toexitCode
, this would be a breaking change tocy.exec()
as the results object is now different.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
? chore: update code to exitCode incy.exec()
cypress-documentation#6247 feat: add cy.exec() Cypress 15 misc test compatibility cypress-example-kitchensink#984type definitions
?