properly handle project-level git config and disable hooks for agent commits #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urations Signed-off-by: Connor Braa <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
Signed-off-by: Connor Braa <[email protected]>
…namic behavior and existing repositories Signed-off-by: Connor Braa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR uses include.path to link user-repo config into the cu fork, so cu commands get essentially the same configuration as the user repo. tests cover all the wild edge cases i could imagine for this -- we support users changing config after fork creation, moving the source repo, etc, etc
this PR also disables git hooks when running hookful commands (commit, merge, etc) -- there's no guarantee that these pass in our copy of the worktree due to missing prerequisite setup commands (that produce gitignored files) and surfacing errors correctly is difficult. it'd be awesome if we could run the hooks inside the env container, but there's no real git repo there.
fixes #256