Skip to content

Conversation

salaboy
Copy link
Collaborator

@salaboy salaboy commented Jun 11, 2025

Description

Adding examples to validate that ZonedDateTime works

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1409

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners June 11, 2025 02:50
@salaboy salaboy marked this pull request as draft June 11, 2025 02:51
@salaboy salaboy force-pushed the 1409-zoneddatetime branch from 58fffef to 4fd0a74 Compare June 11, 2025 02:52
@cicoyle cicoyle added this to the v1.15 milestone Jun 11, 2025
@salaboy salaboy force-pushed the 1409-zoneddatetime branch from 4fd0a74 to 8f93b57 Compare June 17, 2025 01:26
@salaboy salaboy marked this pull request as ready for review June 17, 2025 01:26
@salaboy
Copy link
Collaborator Author

salaboy commented Jul 4, 2025

@dapr/maintainers-java-sdk what is missing for this to be merged?

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch, thank you!

@dapr-bot dapr-bot merged commit 6411797 into dapr:master Jul 14, 2025
9 checks passed
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (d759c53) to head (3d34ec1).
Report is 175 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1413      +/-   ##
============================================
+ Coverage     76.91%   78.36%   +1.44%     
- Complexity     1592     1877     +285     
============================================
  Files           145      234      +89     
  Lines          4843     5832     +989     
  Branches        562      601      +39     
============================================
+ Hits           3725     4570     +845     
- Misses          821      941     +120     
- Partials        297      321      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 6, 2025
…esume) (dapr#1413)

* implementing createtime with zoneddatetime

Signed-off-by: salaboy <[email protected]>

* adding duration and zoneddatetime examples

Signed-off-by: salaboy <[email protected]>

* using external event wf to test suspend resume

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
Signed-off-by: sirivarma <[email protected]>
@siri-varma siri-varma modified the milestones: v1.15, v1.16 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZonedDateTime is not supported for Create Timer
5 participants