-
Notifications
You must be signed in to change notification settings - Fork 223
Use camelCase on properties #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Matheus Cruz <[email protected]>
@salaboy I added as camelCase to support both (spring support camelCase too), WDYT? |
@mcruzdev, thanks for the change, but it will be great if we can add some tests to see if these and the previous ones that you documented both work for the spring boot application.properties. I have the feeling that there are a couple of approaches implemented for different situations, and I am not sure if they are covered by tests. For example if you are using: |
Signed-off-by: Matheus Cruz <[email protected]>
1dbd120
to
8febfa8
Compare
Hi @salaboy we already have a test for it (using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcruzdev could you please take a look and let me know if we can merge this. |
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]>
Sorry @cicoyle and @artur-ciocanu for delay. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
============================================
+ Coverage 76.91% 78.73% +1.81%
- Complexity 1592 1918 +326
============================================
Files 145 237 +92
Lines 4843 5924 +1081
Branches 562 610 +48
============================================
+ Hits 3725 4664 +939
- Misses 821 938 +117
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Change the configuration on documentation to camelCase.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1466
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: