Skip to content

Add a unit test for join method coverage #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a unit test for join method coverage #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e4a9a
Add unit tests for join method coverage
joshu4lim Apr 21, 2025
1619656
Removed proposed test cases and the dead code in _join()
joshu4lim May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions datascience/tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,11 +2036,6 @@ def join(self, column_label, other, other_label=None):

def _join(self, column_label, other, other_label=[]):
"""joins when COLUMN_LABEL is a string"""
if self.num_rows == 0 or other.num_rows == 0:
return None
if not other_label:
other_label = column_label

self_rows = self.index_by(column_label)
other_rows = other.index_by(other_label)
return self._join_helper([column_label], self_rows, other, [other_label], other_rows)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,8 +1659,8 @@ def test_join_without_other_label(table, table2):
2 | b | 3 | two
2 | c | 3 | two
""")


##################
# Export/Display #
##################
Expand Down
Loading