For your consideration #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… splitting and looping through arrays. Should be faster but needs benchmarking against original. TODO: Find a way to preserve html, especially in the dropcap method as it will obliterate inline markup. Signed-off-by: Robert O'Rourke <[email protected]>
…ing system Signed-off-by: Robert O'Rourke <[email protected]>
Added example CSS for creating kerning pairs.
|
Pushing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've made some pretty cool revisions to the plugin while keeping it nice and light.
First off I've removed the need for splitting and looping in the injector using regex so we should see a performance boost.
Secondly I've made each method configurable so an options object can be passed in to modify elements such as the regex, the classes to be output and the base name of the classes.
Thirdly it supports class names that reflect the content of what is wrapped so for words and letters there are class names to match rather than only by number.