vsp: don't set/use a default policy #2129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the possibility of using a previously created vsp client that has a policy different from the one intended by the caller. In most cases already, the caller has a policy defined that should be used rather than some previously set default policy. The only other case where a policy to be used isn't readily handy is in the json-rpc handler for the processUnmanagedTicket method. That method uses the vsp client set in config and should thus use the policy set in config.
itswisdomagain
force-pushed
the
vsp-fee-policy
branch
from
8a73bea to
6b3bc7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the possibility of using a previously created vsp client
that has a policy different from the one intended by the caller.
In most cases already, the caller has a policy defined that should be
used rather than some previously set default policy. The only other
case where a policy to be used isn't readily handy is in the json-rpc
handler for the processUnmanagedTicket method. That method uses the
vsp client set in config and should thus use the policy set in config.
Also, properly assign the
mixedSplitAccountandchangeAccountvarsin the purchaseTicket json-rpc method handler.