Refactor parser logic to better allow subclassing #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves segment parsing logic from private MultipartSegment methods back into the PushMultipartParser where it belongs, and isolates the 'form-data' specific checks into a single private method to allow subclasses to support different segment and steam types (e.g. multipart/byterange or multipart/mixed). change: MultipartSegment.name is now typed as optional, but is still guaranteed to be a string for unmodified versions of the parser.
This was referenced Jul 7, 2025
defnull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix #73 by moving all general purpose parser logic out of
MultipartSegmentback into the parser where it belongs and isolatingform-dataspecific checks into a private parser method which can be overridden. Developers can now subclassPushMultipartParserand override_create_segment(self, headerlist)to support other multipart stream types (e.g.multipart/byterangeormultipart/mixed) if necessary.The change has a minimal impact on performance and actually performs better for the relevant use cases (large forms or large uploads).