TOOL-28497 latest libkdumpfile upstream doesn't build #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the sources of kdumpid v1.6 (commit cb3d9452e2f6) and adapt them so they can be built from libkdumpfile using GNU autotools. The sources are identical, except these changes: - include "config.h" from kdumpid.h - remove some superfluous whitespace The versioning scheme of kdumpid is retained for now to ensure that the versions form a monotonically increasing sequence. The original kdumpid repository will be set to read-only to avoid potential divergence. Signed-off-by: Petr Tesarik <[email protected]>
Autoconf 2.69 cannot handle complex conditional expansions well. To improve compatibility, expand the KDUMP_DIS_ASM macro on its own and then check the kdump_res variable. Fixes: ptesarik#83 Signed-off-by: Petr Tesarik <[email protected]>
The attribute value as a number is a kdump_num_t, which should be formatted using the corresponding PRI_xxx macros. Signed-off-by: Petr Tesarik <[email protected]>
The maximum PFN is obtained with a call to kdump_get_number_attr(), which takes a pointer to a kdump_num_t as its parameter. Signed-off-by: Petr Tesarik <[email protected]>
This include file may conflict with the system <endian.h> (courtesy of Automake adding -I. to compiler flags). Move the content of endian.h to kdumpid.h, because it is included only from that one place anyway. Signed-off-by: Petr Tesarik <[email protected]>
Bump version to 0.5.5. Libtool versioning: - libkdumpfile bumped by commit e182aea - libaddrxlat bumped by this commit kdumpid version: - start with 1.7 (last separate release was 1.6) Signed-off-by: Petr Tesarik <[email protected]>
Before including bfd.h (or any of the headers installed by binutils), one has to define PACKAGE_NAME and PACKAGE_VERSION for kind of painful reasons described in binutils bug PR14243. This doesn't show up on some distros as they patch out the #ifdef check in the headers, but it does on Gentoo where we don't, at least. Moreover, we want to include config.h before *any* headers anyway, so that e.g. AC_SYSTEM_EXTENSIONS and various other autoconf macros work correctly if used. Bug: https://sourceware.org/PR14243 Signed-off-by: Sam James <[email protected]>
addrxlat-priv.h includes config.h for us, but we should include it first to ensure it affects standard headers too given config.h may set feature test macros and so on. Where addrxlat-priv.h is not already used, add config.h instead. Signed-off-by: Sam James <[email protected]>
testutil.h includes config.h for us, but we should include it first to ensure it affects standard headers too given config.h may set feature test macros and so on. Where testutil.h is not already used, add config.h instead. (Same as done earlier for addrxlat-priv.h.) Signed-off-by: Sam James <[email protected]>
tools: kdumpid: include config.h before <dis-asm.h>
Signed-off-by: Petr Tesarik <[email protected]>
Signed-off-by: Petr Tesarik <[email protected]>
The xlat-linux-x86_64-6.11-pti-user and xlat-linux-x86_64-6.11-pti-user-ver test cases use the same input files, but the logic is flawed, because they also use the same output file names. That fails if both run in parallel. Fixes: ptesarik#85 Signed-off-by: Petr Tesarik <[email protected]>
Signed-off-by: Petr Tesarik <[email protected]>
Since util.c calls some functions from libaddrxlat, let's link against that library explicitly instead of relying on its being added as a dependency of libkdumpfile. Fixes: ptesarik#87 Signed-off-by: Petr Tesarik <[email protected]>
Since uncompress_config() uses functions from zlib, kdumpid must link with ZLIB. It may work without it, because ZLIB is often added as a dependency for libbfd, but we should not rely on it. Signed-off-by: Petr Tesarik <[email protected]>
Run "doxygen -u" to refresh the configuration. Signed-off-by: Petr Tesarik <[email protected]>
To close a group, the @} string must appear in a comment that is parsed by Doxygen, i.e. inside a comment that starts with a "/**". Signed-off-by: Petr Tesarik <[email protected]>
sebroy
force-pushed
the
dlpx/pr/sebroy/fa5bb09c-857c-405b-a02f-0d20500c7cc6
branch
from
09dcaec to
400f3ee
Compare
mmaybee
approved these changes
Aug 27, 2025
nealquigley
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest upstream merge doesn't build due to a missing build dependency on
binutils-dev. The package build fails in the configure step like this:The only change I made to get a successful build was the following:
This merge brings us to version 0.5.5.
ab-pre-push: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/12036/console