DLPX-95062 simplify challenge-response package build #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The challenge-response linux-pkg package build is needlessly complex. The linux-pkg framework provides a set of default functions for performing the most common tasks:
install_build_deps_from_control_file
)dpkg_buildpackage_default
)Instead of using these convenience functions, the challenge-response package uses its own set of custom commands and Makefile-based build (which itself calls into debian commands). This can be simplified.
This PR is inter-dependent with https://www.github.com/delphix/challenge-response/pull/9.
The output of this package build is a debian file with the following format and contents:
ab-pre-push (contains changes for both inter-dependent PRs): https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/11888/
The upgrade test failed, but upgrades to develop are generally broken right now. I did verify that the pam-challenge-response module is correctly upgraded in the verify container. Something else is broken with upgrade verify (unrelated to this change).