added confluence-cloud-content-get to Atlassian Confluence Cloud Inte… #40623
Conversation
|
|
content-bot
added
Community
Contribution Form Filled
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/shysh-cmd_feature/add-confluence-cloud-content-get
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed. |
|
Hi @shysh-cmd, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
| def validate_get_content_args(args: dict[str, str]): | ||
| """ | ||
| Validate arguments for confluence-cloud-content-get command, raise ValueError on invalid arguments. | ||
|
|
||
| :type args: ``Dict[str, str]`` | ||
| :param args: The command arguments provided by the user. | ||
|
|
||
| :return: None | ||
| """ | ||
| content_id = args["content_id"] | ||
| if not content_id: | ||
| raise ValueError(MESSAGES["REQUIRED_ARGUMENT"].format("content_id")) | ||
|
|
There was a problem hiding this comment.
no need to add this validation, just add the key "required: true" to the arg in the yml file
| """ | ||
| validate_get_content_args(args) | ||
|
|
||
| content_id = args["content_id"] |
There was a problem hiding this comment.
| content_id = args["content_id"] | |
| content_id = args.get("content_id") |
|
|
||
| content_id = args["content_id"] | ||
| params = {"body-format":"raw"} | ||
| request_url = URL_SUFFIX["CONTENT"] + f"/{content_id}" |
There was a problem hiding this comment.
please use urljoin() from commonserverpython you can rewrite the line as:
request_url = urljoin(URL_SUFFIX.get("CONTENT"), content_id)
and import the function in the integration
| content_id = args["content_id"] | ||
| params = {"body-format":"raw"} | ||
| request_url = URL_SUFFIX["CONTENT"] + f"/{content_id}" | ||
| params = {"expand":"body.storage"} |
There was a problem hiding this comment.
if you add this line like this, it overrides your previous definition: params = {"body-format":"raw"}
| response = client.http_request(method="GET", url_suffix=request_url, params=params) | ||
| response_json = response.json() | ||
|
|
||
| context = remove_empty_elements_for_context(response_json) |
There was a problem hiding this comment.
we already have a common function in CommonServerPython that does this job it's called "remove_empty_elements()" you can use it
| readable_hr = prepare_hr_for_content_create(response_json, "Content") | ||
|
|
||
| return CommandResults( | ||
| outputs_prefix=OUTPUT_PREFIX["CONTENT"], |
There was a problem hiding this comment.
| outputs_prefix=OUTPUT_PREFIX["CONTENT"], | |
| outputs_prefix=OUTPUT_PREFIX.get("CONTENT"), |
| params = {"expand":"body.storage"} | ||
|
|
||
| response = client.http_request(method="GET", url_suffix=request_url, params=params) | ||
| response_json = response.json() |
There was a problem hiding this comment.
if the search returned not found, the command should not return an error, the readable should states that the content was not found and not fail the command, please verify this case
| @@ -2040,6 +2040,12 @@ script: | |||
| - contextPath: ConfluenceCloud.Event.associatedObjects.objectType | |||
| description: Type of the associated object. | |||
| type: String | |||
| - arguments: | |||
There was a problem hiding this comment.
please add the outputs of the command
|
|
||
| ##### Atlassian Confluence Cloud | ||
|
|
||
| - Added support for **confluence-cloud-content-get** command that retrieves a content item by content id. |
There was a problem hiding this comment.
| - Added support for **confluence-cloud-content-get** command that retrieves a content item by content id. | |
| - Added the **confluence-cloud-content-get** command to retrieve a content item. |
merit-maita
added
the
pending-contributor
…gration
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Description
added confluence-cloud-content-get to Atlantis Confluence Cloud Integration
Must have