Cyberark PAS Integration fix get_users

[nitsan-tzur]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

PR fixes incorrect usage of body in a GET request, switching to query params

Must have

• Tests
• Documentation

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 6 committers have signed the CLA.

✅ eyalpalo
✅ itssapir
✅ MosheEichler
❌ idovandijk
❌ nitsan-tzur
❌ tcarmeli1
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @nitsan-tzur, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[merit-maita]

Hello @nitsan-tzur
first of all, thank you for your contribution!
but why did you make this change to this api call in specific? and based on why did you decide to make this change?

[nitsan-tzur]

Hello @nitsan-tzur first of all, thank you for your contribution! but why did you make this change to this api call in specific? and based on why did you decide to make this change?

Hi @merit-maita ,
As its a GET request without a body, we've noticed that data is not processed correctly. It does work as expected when passed as query params

[merit-maita]

@nitsan-tzur
based on the api docs, you're right, thank you for pointing this out!
i'll proceed with your contribution, just please add rn to the pr to be able to merge it.

[nitsan-tzur]

@nitsan-tzur based on the api docs, you're right, thank you for pointing this out! i'll proceed with your contribution, just please add rn to the pr to be able to merge it.

Thanks @merit-maita
What do you mean in adding rn?

[merit-maita]

@nitsan-tzur based on the api docs, you're right, thank you for pointing this out! i'll proceed with your contribution, just please add rn to the pr to be able to merge it.

Thanks @merit-maita What do you mean in adding rn?

RN means Release Note. you can run "demisto-sdk update-release-notes" and the file will be generated you'd just have to edit it to state the changes made.

[nitsan-tzur]

@nitsan-tzur based on the api docs, you're right, thank you for pointing this out! i'll proceed with your contribution, just please add rn to the pr to be able to merge it.

Thanks @merit-maita What do you mean in adding rn?

RN means Release Note. you can run "demisto-sdk update-release-notes" and the file will be generated you'd just have to edit it to state the changes made.

Done