-
Notifications
You must be signed in to change notification settings - Fork 152
Implement E2E tests for all possible new authorization flows. #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s-e2e' into sea-snake/new-authorization-flows-e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking very good!
Mainly suggestions to improve the comments.
Regarding the missing tests, we can do them in another PR.
Already approving, but please improve the comments before merging.
src/frontend/src/routes/(new-styling)/authorize/(authenticated)/account/+page.svelte
Outdated
Show resolved
Hide resolved
src/frontend/tests/e2e/(new-styling)/authorize/continue.test.ts
Outdated
Show resolved
Hide resolved
…s-e2e' into sea-snake/new-authorization-flows-e2e
# Conflicts: # src/frontend/src/routes/(new-styling)/authorize/(authenticated)/account/+page.svelte # src/frontend/src/routes/(new-styling)/authorize/continue/+page.svelte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, are the TODOs still TODO or just leftover comments?
Ah good catch, those are leftover changes from before I moved to PlayWright + DummyAuth. I'll remove them. |
Implement E2E tests for all possible new authorization flows.
Changes
Tests