Skip to content

Implement E2E tests for all possible new authorization flows. #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 17, 2025

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Jun 2, 2025

Implement E2E tests for all possible new authorization flows.

Changes

  • Implement PlayWright for new authorization flow e2e tests
  • Add pipeline for PlayWright e2e tests
  • Implement E2E tests covering all user flows across the new authorize routes.

Tests

  • Added 8 tests across 3 files.
  • Manually ran all these tests on both desktop and mobile to visually verify they behaved as expected.

@sea-snake sea-snake requested a review from lmuntaner June 2, 2025 11:49
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking very good!

Mainly suggestions to improve the comments.

Regarding the missing tests, we can do them in another PR.

Already approving, but please improve the comments before merging.

@sea-snake sea-snake requested a review from LXIF June 17, 2025 09:46
Copy link
Contributor

@LXIF LXIF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, are the TODOs still TODO or just leftover comments?

@sea-snake
Copy link
Contributor Author

LGTM in general, are the TODOs still TODO or just leftover comments?

Ah good catch, those are leftover changes from before I moved to PlayWright + DummyAuth. I'll remove them.

@sea-snake sea-snake added this pull request to the merge queue Jun 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2025
@sea-snake sea-snake added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 359090d Jun 17, 2025
76 checks passed
@sea-snake sea-snake deleted the sea-snake/new-authorization-flows-e2e branch June 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants