test for compute_cve()

[yucongalicechen]

• closes test for compute_cve() #20
• Initial commit
• I have to add the line n_points_on_diameter=N_POINTS_ON_DIAMETER to make monkeypatch work in the test. It doesn't affect the current functionality but is probably not the desired behavior.. Any suggestions for this?

[sbillinge]

I would like to unify our mocking to pytest mocker. Please search in recent diffpy .I told where I did this

…

On Fri, Jun 14, 2024, 9:38 AM Yucong (Alice) Chen ***@***.***> wrote: - closes #20 <#20> - Initial commit - I have to add the line n_points_on_diameter=N_POINTS_ON_DIAMETER to make monkeypatch work in the test. It doesn't affect the current functionality but is probably not the desired behavior.. Any suggestions for this? ------------------------------ You can view, comment on, or merge this pull request online at: #78 Commit Summary - 82078ab <82078ab> initial commit, tests pass locally with a minor tweak in function File Changes (2 files <https://github.com/diffpy/diffpy.labpdfproc/pull/78/files>) - *M* src/diffpy/labpdfproc/functions.py <https://github.com/diffpy/diffpy.labpdfproc/pull/78/files#diff-b2417329694bd3fa0a26f3eedaad32c2d94e49b169aec5215d2b5e6909f4bee0> (2) - *M* src/diffpy/labpdfproc/tests/test_functions.py <https://github.com/diffpy/diffpy.labpdfproc/pull/78/files#diff-89f1294c371d0300af99a8468a2bdf9c5d3c4e52da0b1efb1b6e70958135a340> (30) Patch Links: - https://github.com/diffpy/diffpy.labpdfproc/pull/78.patch - https://github.com/diffpy/diffpy.labpdfproc/pull/78.diff — Reply to this email directly, view it on GitHub <#78>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAOWUORRLGACGF4OW7IOATZHLW3XAVCNFSM6AAAAABJKMF6UCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TGNBQHAYDMMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sbillinge]

this is failing CI. It can't find mocker for some reason. I don't immediately see the problem, but please take a look.

[yucongalicechen]

Oh okay, I will look into this.
I'm also thinking if we want to update package info in this function. It might be easier to maintain/check if we load the package info into "input_pattern" DO along with other things in args. But would it make more sense to update the package here?

[sbillinge]

Oh okay, I will look into this. I'm also thinking if we want to update package info in this function. It might be easier to maintain/check if we load the package info into "input_pattern" DO along with other things in args. But would it make more sense to update the package here?

I'm not really sure. I think in general we may want to update package_info whenever a package is used. The way we implemented it was that it was a set, so each package would only appear once, regardless how often it is used. From this point of view, we may want to just update labpdfproc once near the beginning of when it is used. If it doesn't already, we may want diffpy_utils to update whenever a DO is instantiated, but that would happen in diffpy.utils not here.

tl;dr, I don't think we need it here, but I do think we need it in labpdfprocapp somewhere.

[yucongalicechen]

Got it. So this would be similar to loading user info into args. I'll talk to Steven to see if he could work on that.

[sbillinge]

nice!