Skip to content

skpkg: migrate documentation, README, and public static files #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 11, 2025

Conversation

ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jun 10, 2025

No description provided.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (a4582ee) to head (daf5c8b).
Report is 8 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration     #283   +/-   ##
==========================================
  Coverage      95.10%   95.10%           
==========================================
  Files             23       23           
  Lines           1123     1123           
==========================================
  Hits            1068     1068           
  Misses            55       55           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao ycexiao marked this pull request as ready for review June 10, 2025 20:51
@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 10, 2025

@sbillinge , it's ready for review.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bring over license.rst and index.rst from the old packages without changes. Then also address my comments. Thx

@@ -4,94 +4,49 @@

.. |title| replace:: diffpy.pdfgui documentation

diffpy.pdfgui - GUI for PDF simulation and structure refinement.
``diffpy.pdfgui`` - Graphical user interface program for structure refinements to atomic pair distribution function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "the" in here too


For users who do not have the expertise or necessity for command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few more comments.

@@ -0,0 +1,79 @@
:tocdepth: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entire file needs to be deleted. There is pdfgui documentation so we don't need this stub. Also the skpkg logo

@@ -0,0 +1,28 @@
.. list-table:: 5 levels of reusing/sharing code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this example doc file also should be deleted

@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 10, 2025

@sbillinge , it's ready for review.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there...I caught one last thing.

@@ -0,0 +1,31 @@
.. _example_package documentation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ycexiao sorry I missed this stub file too. This needs to be deleted.

@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 11, 2025

@sbillinge , it's ready for review.

@sbillinge sbillinge merged commit 4af7868 into diffpy:migration Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants