-
Notifications
You must be signed in to change notification settings - Fork 37
skpkg: migrate documentation, README, and public static files #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #283 +/- ##
==========================================
Coverage 95.10% 95.10%
==========================================
Files 23 23
Lines 1123 1123
==========================================
Hits 1068 1068
Misses 55 55 🚀 New features to boost your workflow:
|
@sbillinge , it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please bring over license.rst
and index.rst
from the old packages without changes. Then also address my comments. Thx
doc/source/index.rst
Outdated
@@ -4,94 +4,49 @@ | |||
|
|||
.. |title| replace:: diffpy.pdfgui documentation | |||
|
|||
diffpy.pdfgui - GUI for PDF simulation and structure refinement. | |||
``diffpy.pdfgui`` - Graphical user interface program for structure refinements to atomic pair distribution function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "the" in here too
doc/source/index.rst
Outdated
|
||
For users who do not have the expertise or necessity for command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few more comments.
doc/source/getting-started.rst
Outdated
@@ -0,0 +1,79 @@ | |||
:tocdepth: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire file needs to be deleted. There is pdfgui documentation so we don't need this stub. Also the skpkg logo
@@ -0,0 +1,28 @@ | |||
.. list-table:: 5 levels of reusing/sharing code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example doc file also should be deleted
@sbillinge , it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nearly there...I caught one last thing.
@@ -0,0 +1,31 @@ | |||
.. _example_package documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ycexiao sorry I missed this stub file too. This needs to be deleted.
@sbillinge , it's ready for review. |
No description provided.