-
Notifications
You must be signed in to change notification settings - Fork 29
Relax dependencies #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax dependencies #101
Conversation
@wolfgangwalther thanks for PR |
merged in #103 |
@wolfgangwalther published as 0.11.2.3 |
Thank you! |
So this builds fine, runs the package tests fine, runs the NixOS integration test fine. But when I use it in my project, each websocket connection is immediately lost again and postgres-websockets shows this output:
In a loong debugging session I nailed this down to Maybe you have more insight, maybe you can reproduce, maybe you have any idea what's going on? (the related change in that 0.1.1 -> 0.1.2 update was this PR: yesodweb/wai#1013) |
@wolfgangwalther thanks for putting in the time to narrow down the issue. I'll try to reproduce later today. |
@wolfgangwalther I cannot reproduce using the sample project and the README steps. My build plan, however, is resolving Could you retry your debugging session pinning the warp version to |
I have tested time-manager 0.1.2, 0.1.3 and also 0.2.2 (the latter is the default in nixpkgs right now, so that's where the failure started for me). All of them fail. Only 0.1.1 works. Edit: And yes, that was with warp 3.4.7. |
And can you see the problem using the sample chat app? |
Some more settings from my project. I varied those, they didn't make a difference, but you never know:
Also we are requesting the URL without channel, and pass that in the |
You mean https://github.com/diogob/postgres-websockets/tree/master/client-example, right? I have never used it, will need to figure out how to use that with the nix-built executable. |
In case it helps: I do get the same connection failure when connecting via Given that it reproduces with websocat, I think it's unrelated to the client. |
Reason for the failure is still unclear and it was not possible to reproduce outside nixpkgs, yet. diogob/postgres-websockets#101 (comment)
on my end I'll try to reproduce using nix to build it. Let's continue this conversation on #105 |
Reason for the failure is still unclear and it was not possible to reproduce outside nixpkgs, yet. diogob/postgres-websockets#101 (comment)
Reason for the failure is still unclear and it was not possible to reproduce outside nixpkgs, yet. diogob/postgres-websockets#101 (comment)
Reason for the failure is still unclear and it was not possible to reproduce outside nixpkgs, yet. diogob/postgres-websockets#101 (comment) (cherry picked from commit 4e216d5)
Currently, postgres-websockets is marked as broken in nixpkgs, because it doesn't build. I am trying to unbreak it.
With the latest master branch and based on NixOS/nixpkgs#371032, I get the following failure:
All of them can be relaxed and the result builds and runs the tests fine.
I effectively tested this with:
Do you think it would be possible to cut a new release with this and all the changes on the master branch? That would unbreak the package in nixpkgs :)