Skip to content

Grammar & Clarity Fixes #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Grammar & Clarity Fixes #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acccc7d
Update PermanentOwnable.sol
donatik27 Feb 22, 2025
f484b57
Update AbstractPoolContractsRegistry.sol
donatik27 Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/access/PermanentOwnable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pragma solidity ^0.8.4;
* The owner is set to the address provided by the deployer. The ownership cannot be further changed.
*
* This module will make available the modifier `onlyOwner`, which can be applied
* to your functions to restrict their use to the owners.
* to your functions to restrict their use to the owner.
*/
abstract contract PermanentOwnable {
address private immutable _OWNER;
Expand All @@ -28,7 +28,7 @@ abstract contract PermanentOwnable {
* @param owner_ the address of the permanent owner.
*/
constructor(address owner_) {
require(owner_ != address(0), "PermanentOwnable: zero address can not be the owner");
require(owner_ != address(0), "PermanentOwnable: zero address cannot be the owner");

_OWNER = owner_;
}
Expand Down
4 changes: 2 additions & 2 deletions contracts/contracts-registry/pools/AbstractPoolContractsRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
/**
* @notice The function to add new pools into the registry. Gets called from PoolFactory
*
* Proper only factory access control must be added in descending contracts + `_addProxyPool()` should be called inside.
* Proper only factory access control must be added in descendant contracts + `_addProxyPool()` should be called inside.
*
* @param name_ the pool's associated name
* @param poolAddress_ the proxy address of the pool
Expand Down Expand Up @@ -91,7 +91,7 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
* @notice The function to check if the address is a pool
* @param name_ the associated pools name
* @param pool_ the address to check
* @return true if pool_ is whithing the registry
* @return true if pool_ is within the registry
*/
function isPool(string memory name_, address pool_) public view returns (bool) {
return _pools[name_].contains(pool_);
Expand Down