Fix: make button shortcode fully clickable #22811
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 task
|
@crazy-max ptal 🤗 |
crazy-max
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue described in #22806, which I originally opened to highlight a UX inconsistency with the
{{< button >}}shortcode. The current implementation renders a<div>wrapping an<a>element, causing only the text inside the anchor to be clickable. This creates a misleading user experience, as the rest of the styled "button" area is non-interactive.Fix: Updated the
layouts/shortcodes/button.htmlto render the<a>element directly with the required button classes (button not-prose), ensuring the full visual button area is clickable and behaves as expected.Related issues or tickets
Closes #22806
Reviews