chore: Ensure EventProcessor::OnEndValidationStage is called when critical validation error contained
#2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tical validation contained
filzrev
force-pushed
the
chore-modify-eventprocessor-call
branch
from
1a42172 to
6a2a9d0
Compare
timcassell
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modify
EventProcessor::OnEndValidationStageinvoke timing to ensureOnEndValidationStageis called when validation failed.Background
I want to handle validation errors on
EventProcessor::OnEndValidationStageevent to grouping errors perBenchmarkCase.But on current implementation.
EventProcessor::OnEndValidationStageis not called when ValidationErrors contains critical error.